From: markn@au1.ibm.com
To: linux-ext4@vger.kernel.org
Cc: akpm@linux-foundation.org
Subject: [patch 2/2] move init_ext4_proc() last and add cleanup call exit_ext4_proc()
Date: Tue, 09 Oct 2007 15:50:35 +1000 [thread overview]
Message-ID: <20071009061102.363619477@au1.ibm.com> (raw)
In-Reply-To: 20071009055033.145153755@au1.ibm.com
[-- Attachment #1: ext4-move-init_ext4_proc-add-cleanup.patch --]
[-- Type: text/plain, Size: 1052 bytes --]
The first problem that is addressed is that the addition of init_ext4_proc()
means that the code doesn't clean up after itself on a failure of
init_ext4_xattr(), and the second is that usually init_*_proc() should be
the last thing called, so we move it to the end and add the cleanup call to
exit_ext4_proc().
Signed-off-by: Mark Nelson <markn@au1.ibm.com>
---
fs/ext4/super.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
Index: ext4/fs/ext4/super.c
===================================================================
--- ext4.orig/fs/ext4/super.c
+++ ext4/fs/ext4/super.c
@@ -2999,10 +2999,6 @@ static int __init init_ext4_fs(void)
{
int err;
- err = init_ext4_proc();
- if (err)
- return err;
-
err = init_ext4_xattr();
if (err)
return err;
@@ -3012,7 +3008,12 @@ static int __init init_ext4_fs(void)
err = register_filesystem(&ext4dev_fs_type);
if (err)
goto out;
+ err = init_ext4_proc();
+ if (err)
+ goto out_proc;
return 0;
+out_proc:
+ exit_ext4_proc();
out:
destroy_inodecache();
out1:
--
next prev parent reply other threads:[~2007-10-09 6:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 5:50 [patch 0/2] ext4 fixups for 2.6.23-rc8-mm2/ext4 git tree markn
2007-10-09 5:50 ` [patch 1/2] add init_ext4_proc() stub for when CONFIG_PROC_FS is not set markn
2007-10-09 16:31 ` Badari Pulavarty
2007-10-09 17:03 ` Mingming Cao
2007-10-09 17:28 ` Badari Pulavarty
2007-10-09 17:40 ` Theodore Tso
2007-10-10 0:22 ` Theodore Tso
2007-10-10 15:30 ` Badari Pulavarty
2007-10-10 19:00 ` Theodore Tso
2007-10-11 20:00 ` Badari Pulavarty
2007-10-10 0:22 ` Mark Nelson
2007-10-09 5:50 ` markn [this message]
2007-10-09 16:22 ` [patch 2/2] move init_ext4_proc() last and add cleanup call exit_ext4_proc() Badari Pulavarty
2007-10-10 0:11 ` Mark Nelson
2007-10-10 0:34 ` Theodore Tso
2007-10-10 0:41 ` Theodore Tso
2007-10-10 0:50 ` Mark Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071009061102.363619477@au1.ibm.com \
--to=markn@au1.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.