All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Badari Pulavarty <pbadari@gmail.com>
Cc: markn@au1.ibm.com, ext4 <linux-ext4@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	cmm@us.ibm.com
Subject: Re: [patch 2/2] move init_ext4_proc() last and add cleanup call exit_ext4_proc()
Date: Tue, 9 Oct 2007 20:34:44 -0400	[thread overview]
Message-ID: <20071010003444.GM31713@thunk.org> (raw)
In-Reply-To: <1191946922.12131.26.camel@dyn9047017100.beaverton.ibm.com>

On Tue, Oct 09, 2007 at 09:22:02AM -0700, Badari Pulavarty wrote:
> The best way is to make init_ext4_proc() cleanup itself, in case
> of an error. Hmm.. we are not handling proc_mkdir(EXT4_ROOT) 
> failures.

That's actually OK; if proc_root_ext4 is NULL, the procfs routines
should deal just fine.

						- Ted

  parent reply	other threads:[~2007-10-10  0:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-09  5:50 [patch 0/2] ext4 fixups for 2.6.23-rc8-mm2/ext4 git tree markn
2007-10-09  5:50 ` [patch 1/2] add init_ext4_proc() stub for when CONFIG_PROC_FS is not set markn
2007-10-09 16:31   ` Badari Pulavarty
2007-10-09 17:03     ` Mingming Cao
2007-10-09 17:28       ` Badari Pulavarty
2007-10-09 17:40       ` Theodore Tso
2007-10-10  0:22         ` Theodore Tso
2007-10-10 15:30           ` Badari Pulavarty
2007-10-10 19:00             ` Theodore Tso
2007-10-11 20:00               ` Badari Pulavarty
2007-10-10  0:22     ` Mark Nelson
2007-10-09  5:50 ` [patch 2/2] move init_ext4_proc() last and add cleanup call exit_ext4_proc() markn
2007-10-09 16:22   ` Badari Pulavarty
2007-10-10  0:11     ` Mark Nelson
2007-10-10  0:34     ` Theodore Tso [this message]
2007-10-10  0:41   ` Theodore Tso
2007-10-10  0:50     ` Mark Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071010003444.GM31713@thunk.org \
    --to=tytso@mit.edu \
    --cc=akpm@linux-foundation.org \
    --cc=cmm@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=markn@au1.ibm.com \
    --cc=pbadari@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.