From: Matthew Wilcox <matthew@wil.cx>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Save some bytes in scsi_cmnd by rearranging members
Date: Tue, 9 Oct 2007 06:08:48 -0600 [thread overview]
Message-ID: <20071009120848.GC13842@parisc-linux.org> (raw)
In-Reply-To: <470B4D13.8000705@panasas.com>
On Tue, Oct 09, 2007 at 11:42:43AM +0200, Boaz Harrosh wrote:
> Please don't do this patch for now. This is because of the
> soon to come scsi_data_buffer patch that rearages most of the members above
> and puts them in a substructure. Maybe after the scsi_data_buffer patch you can
> try to do this again.
Need to be careful with sub-structures. They can cause more waste; for
example scsi_pointer (on 64-bit) has 4 bytes wasted at the end that
can't be filled when it's embedded into the scsi_cmnd.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-10-09 12:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 23:50 [PATCH] Save some bytes in scsi_cmnd by rearranging members Matthew Wilcox
2007-10-09 9:42 ` Boaz Harrosh
2007-10-09 12:08 ` Matthew Wilcox [this message]
2007-10-09 18:06 ` Matthew Wilcox
2007-10-11 6:19 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071009120848.GC13842@parisc-linux.org \
--to=matthew@wil.cx \
--cc=bharrosh@panasas.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.