Re: [PATCH] b43: Use input-polldev for the rfkill switch

[Michael Buesch <mb@bu3sch.de>]

On Wednesday 10 October 2007 16:30:35 Dmitry Torokhov wrote:
> Hi Michael,
> 
> On 9/28/07, Michael Buesch <mb@bu3sch.de> wrote:
> > This removes the direct call to rfkill on an rfkill event
> > and replaces it with an input device. This way userspace is also
> > notified about the event.
> >
> > Signed-off-by: Michael Buesch <mb@bu3sch.de>
> >
> > Index: wireless-2.6/drivers/net/wireless/b43/Kconfig
> > ===================================================================
> > --- wireless-2.6.orig/drivers/net/wireless/b43/Kconfig  2007-09-27 21:31:15.000000000 +0200
> > +++ wireless-2.6/drivers/net/wireless/b43/Kconfig       2007-09-28 12:34:23.000000000 +0200
> > @@ -70,7 +70,7 @@ config B43_LEDS
> >  # RFKILL support
> >  config B43_RFKILL
> >        bool
> > -       depends on B43 && RFKILL
> > +       depends on B43 && RFKILL && RFKILL_INPUT && INPUT_POLLDEV
> >        default y
> 
> I don't think that broadcom driver should depend on RFKILL_INPUT...
> RFKILL_INPUT is a default link between input and rfkill layers but it
> is by no means a mandatory component.
> 
> I think proper dependency should be:
> 
>         depends on B43 && RFKILL && INPUT
>         select INPUT_POLLDEV
> 

b43 rfkill support is useless without also having RFKILL_INPUT, as
the button reporting is done though it.
b43 does _not_ depend on RFKILL_INPUT, but b43-rfkill support is disabled,
if there's no RFKILL_INPUT compiled.

-- 
Greetings Michael.