Re: [PATCH] b43: Use input-polldev for the rfkill switch

[Michael Buesch <mb@bu3sch.de>]

On Wednesday 10 October 2007 16:51:38 Dmitry Torokhov wrote:
> > > I don't think that broadcom driver should depend on RFKILL_INPUT...
> > > RFKILL_INPUT is a default link between input and rfkill layers but it
> > > is by no means a mandatory component.
> > >
> > > I think proper dependency should be:
> > >
> > >         depends on B43 && RFKILL && INPUT
> > >         select INPUT_POLLDEV
> > >
> >
> > b43 rfkill support is useless without also having RFKILL_INPUT, as
> > the button reporting is done though it.
> > b43 does _not_ depend on RFKILL_INPUT, but b43-rfkill support is disabled,
> > if there's no RFKILL_INPUT compiled.
> >
> 
> No, it is not. One can have a userspace daemon claiming the rfkill
> switch...

No, that's impossible with b43.

> We normally specify dependencies that are needed to build the code,
> not necessarily to use it. It's like various joystick drivers do not
> depend on joydev or evdev modules although most people would need
> these modules as well to use their joysticks. Or SCSI drivers don't
> depend on sd or sr being selected, etc, etc.

Yeah, well. As I said. This is not a dependency. It's an auto-select
option, which automatically selects the code.

-- 
Greetings Michael.