Re: [RFC PATCH v4 1/3] [SELinux] Add a capabilities bitmap to SELinux policy version 22

[Paul Moore <paul.moore@hp.com>]

On Wednesday 10 October 2007 5:02:15 pm Eric Paris wrote:
> On 10/10/07, Paul Moore <paul.moore@hp.com> wrote:
> > On Wednesday 10 October 2007 2:16:34 pm Stephen Smalley wrote:
> > > On Fri, 2007-10-05 at 15:32 -0400, Paul Moore wrote:
> > > > @@ -1304,6 +1307,9 @@ int security_load_policy(void *data, size_t
> > > > len) return -EINVAL;
> > > >             }
> > > >             policydb_loaded_version = policydb.policyvers;
> > > > +           selinux_policycap_netpeer =
> > > > +             ebitmap_get_bit(&policydb.policycaps,
> > > > +                             POLICYDB_CAPABILITY_NETPEER);
> > > >             ss_initialized = 1;
> > > >             seqno = ++latest_granting;
> > > >             LOAD_UNLOCK;
> > >
> > > Only handles the initial policy load case, not reloads.
> >
> > So it does, thanks.  I just added the same assignment further down in the
> > security_load_policy() function to handle the reload case.
>
> Do we expect to have more of these?  are we going to keep making
> load_policy larger and larger or should this type of assignment just
> be made in its own function to start with?

My crystal ball is a bit hazy, but I think it's reasonable to expect that we 
will get more of these variables in the future.  I'll move it out to a 
separate function unless I hear any strong objections.

-- 
paul moore
linux security @ hp

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.