From: Dave Jones <davej@redhat.com>
To: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: Herbert Xu <herbert.xu@redhat.com>,
netdev@vger.kernel.org, esandeen@redhat.com, dmack@juniper.net
Subject: Re: e100 problems in .23rc8 ?
Date: Thu, 11 Oct 2007 13:25:51 -0400 [thread overview]
Message-ID: <20071011172551.GA21339@redhat.com> (raw)
In-Reply-To: <470E4AFA.60507@intel.com>
On Thu, Oct 11, 2007 at 09:10:34AM -0700, Kok, Auke wrote:
> Herbert Xu wrote:
> > On Wed, Oct 10, 2007 at 08:36:38PM -0400, Dave Jones wrote:
> >> The e1000 changes you reference above, is this the changeset you mean?
> >>
> >> commit 416b5d10afdc797c21c457ade3714e8f2f75edd9
> >> Author: Auke Kok <auke-jan.h.kok@intel.com>
> >> Date: Fri Jun 1 10:22:39 2007 -0700
> >>
> >> e1000: disable polling before registering netdevice
> >
> > Yep.
>
> this patch actually called napi_disable() in the probe routine which was wrong,
> but e100 does not do that. Nonetheless e100 doesn't call netif_carrier_off() and
> netif_stop_queue(), so to make e100 the same as e1000 we should probably do this,
> see below.
>
> Dave, can you see if this resolves the issue for you? If so then we might want to
> push this to -stable.
Will do, thanks Auke.
Eric/David, the Fedora 8 RPM version 2.6.23-6.fc8 will have this if you
want to give it a shot too. It'll be at
http://people.redhat.com/davej/kernels/Fedora/f7.92/ when it's done
building in an hour or so.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-10-11 17:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 15:04 e100 problems in .23rc8 ? Dave Jones
2007-09-26 18:10 ` Kok, Auke
2007-09-26 18:18 ` Dave Jones
2007-09-27 6:58 ` Herbert Xu
2007-10-11 0:36 ` Dave Jones
2007-10-11 1:25 ` Herbert Xu
2007-10-11 16:10 ` Kok, Auke
2007-10-11 17:25 ` Dave Jones [this message]
2007-10-11 18:56 ` Eric Sandeen
2007-10-12 14:54 ` David Mack
2007-10-12 15:35 ` Herbert Xu
2007-10-12 15:51 ` David Mack
2007-10-13 2:35 ` Herbert Xu
2007-10-16 14:33 ` Eric Sandeen
2007-10-16 14:35 ` Herbert Xu
2007-10-16 15:47 ` Eric Sandeen
2007-10-16 16:39 ` David Mack
2007-10-12 17:04 ` Kok, Auke
2007-10-18 17:51 ` David Mack
2007-10-18 17:59 ` Kok, Auke
2007-10-18 18:17 ` Chuck Ebbert
2007-10-22 1:04 ` Dave Jones
2007-10-22 3:10 ` Herbert Xu
2007-10-22 14:05 ` David Mack
2007-10-22 14:59 ` Eric Sandeen
2007-10-22 14:44 ` Chuck Ebbert
2007-10-11 23:24 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071011172551.GA21339@redhat.com \
--to=davej@redhat.com \
--cc=auke-jan.h.kok@intel.com \
--cc=dmack@juniper.net \
--cc=esandeen@redhat.com \
--cc=herbert.xu@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.