From: Arnd Bergmann <arnd@arndb.de>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, david@gibson.dropbear.id.au
Subject: Re: [PATCH] PowerPC: Fix find_legacy_serial_ports on OPB.
Date: Thu, 11 Oct 2007 19:09:39 +0200 [thread overview]
Message-ID: <200710111909.39927.arnd@arndb.de> (raw)
In-Reply-To: <1192118028.5534.123.camel@localhost.localdomain>
On Thursday 11 October 2007, Josh Boyer wrote:
> Wait, no. =A0We already had this discussion months ago when David was
> working on the original Ebony port. =A0It was declared that legacy_serial
> is not how serial should be done on 4xx and the serial_of driver was
> supposed to be used instead.
>=20
> Have we changed our stance on that? =A0If not, then perhaps KGDB should be
> fixed to work with serial_of.
I guess I'm fine with a patch that removes the OPB probing from
legacy_serial, but as long as it's there it should work on all
platforms.
Note that of_serial and legacy_serial are not exclusive, as of_serial
will simply take over all ports that have previously been registered
by the legacy code. Probing them early has the advantage that you
can see many printk messages earlier when the of_serial initialization
has not been called yet.
Arnd <><
next prev parent reply other threads:[~2007-10-11 17:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 15:26 [PATCH] PowerPC: Fix find_legacy_serial_ports on OPB Valentine Barshak
2007-10-11 15:50 ` Arnd Bergmann
2007-10-11 15:53 ` Josh Boyer
2007-10-11 17:09 ` Arnd Bergmann [this message]
2007-10-11 19:09 ` [PATCH] PowerPC: Add legacy serial support for OPB with flattened device tree Valentine Barshak
2007-10-11 21:10 ` Arnd Bergmann
2007-10-11 17:26 ` [PATCH] PowerPC: Fix find_legacy_serial_ports on OPB Valentine Barshak
2007-10-11 18:31 ` Josh Boyer
2007-10-12 2:31 ` David Gibson
2007-10-12 11:49 ` Josh Boyer
2007-10-11 18:49 ` Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710111909.39927.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=david@gibson.dropbear.id.au \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.