From: Dave Jones <davej@redhat.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Kevin <spaceman__spiff@cox.net>, Greg KH <greg@kroah.com>,
Olof Johansson <olof@lixom.net>, Greg KH <gregkh@suse.de>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"Theodore Ts'o" <tytso@mit.edu>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
Justin Forbes <jmforbes@linuxtx.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Chris Wedgwood <reviews@ml.cw.f00f.org>,
Domenico Andreoli <cavokz@gmail.com>, Mark Lord <mlord@pobox.com>,
Randy Dunlap <rdunlap@xenotime.net>,
Michael Krufky <mkrufky@linuxtv.org>,
Chuck Ebbert <cebbert@redhat.com>,
akpm@linux-foundation.org, Chuck Wolber <chuckw@quantumlinux.com>,
stable@kernel.org, alan@lxorguk.ukuu.org.uk,
BDFL <volkerdi@slackware.com>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: ARPM shutdown oops (Re: [stable] [patch 09/12] Fix SMP poweroff hangs)
Date: Thu, 11 Oct 2007 15:19:17 -0400 [thread overview]
Message-ID: <20071011191917.GA11732@redhat.com> (raw)
In-Reply-To: <470E6E79.6040908@pobox.com>
On Thu, Oct 11, 2007 at 02:42:01PM -0400, Jeff Garzik wrote:
> Linus Torvalds wrote:
> >
> > And I think I see the problem: it's a config change. You don't have
> > PM_LEGACY enabled. Your config file diff shows:
> >
> > -CONFIG_PM_LEGACY=y
> > +# CONFIG_PM_LEGACY is not set
> >
> > I suspect we should make CONFIG_APM either depend on, or select,
> > PM_LEGACY. But as far as I can see, nothing has actually changed in this
> > area in the kernel, and this bug has been there before - just your config
> > change made it appear.
> >
> > Rafael? Stephen? Opinions? I'd think that making APM depend on
> > CONFIG_PM_LEGACY is the right thing to do these days..
>
> Speaking as the author of
>
> [PATCH] move pm_register/etc. to CONFIG_PM_LEGACY, pm_legacy.h
>
> I agree. arch/i386/kernel/apm.c clearly requires
> include/linux/pm_legacy.h and the legacy PM API.
>
> I would vote for a dependency rather than select, but don't have any
> strong feelings on the matter...
gti revert 987d4613e52e4f655278265aabbcc69237018b1d
should do the trick.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-10-11 19:32 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071008180406.052382073@mini.kroah.org>
2007-10-08 18:05 ` [patch 00/12] 2.6.22.10 -stable review Greg KH
2007-10-08 18:06 ` [patch 01/12] scsi_transport_spi: fix domain validation failure from incorrect width setting Greg KH
2007-10-08 18:06 ` [patch 02/12] sky2: reduce impact of watchdog timer Greg KH
2007-10-08 18:06 ` [patch 03/12] sky2: fix VLAN receive processing Greg KH
2007-10-08 18:06 ` [patch 04/12] sky2: fix transmit state on resume Greg KH
2007-10-08 18:06 ` [patch 05/12] libata: update drive blacklists Greg KH
2007-10-08 18:06 ` [patch 06/12] Fix ppp_mppe kernel stack usage Greg KH
2007-10-08 18:06 ` [patch 07/12] i2c-algo-bit: Read block data bugfix Greg KH
2007-10-08 18:06 ` [patch 08/12] NLM: Fix a circular lock dependency in lockd Greg KH
2007-10-08 20:01 ` Roel Kluin
2007-10-09 15:00 ` Trond Myklebust
2007-10-09 15:13 ` Greg KH
2007-10-09 15:27 ` Trond Myklebust
2007-10-09 20:41 ` [stable] " Greg KH
2007-10-08 18:06 ` [patch 09/12] Fix SMP poweroff hangs Greg KH
2007-10-09 15:17 ` Olof Johansson
2007-10-09 22:20 ` [stable] " Greg KH
2007-10-09 23:21 ` Thomas Gleixner
2007-10-09 23:27 ` Linus Torvalds
2007-10-09 23:35 ` Thomas Gleixner
2007-10-10 5:29 ` Linus Torvalds
[not found] ` <200710092359.47144.spaceman__spiff@cox.net>
2007-10-10 14:57 ` ARPM shutdown oops (Re: [stable] [patch 09/12] Fix SMP poweroff hangs) Linus Torvalds
2007-10-10 16:31 ` H. Peter Anvin
2007-10-11 3:05 ` Kevin
2007-10-11 15:31 ` Linus Torvalds
2007-10-11 18:42 ` Jeff Garzik
2007-10-11 19:19 ` Dave Jones [this message]
2007-10-11 20:55 ` Rafael J. Wysocki
2007-10-11 23:27 ` APM " Adrian Bunk
2007-10-12 12:05 ` Rafael J. Wysocki
2007-10-10 0:03 ` [stable] [patch 09/12] Fix SMP poweroff hangs Olof Johansson
2007-10-10 0:03 ` Olof Johansson
2007-10-10 0:08 ` [PATCH] powerpc: don't enable cpu hotplug on mpic-based pseries Olof Johansson
2007-10-10 0:08 ` Olof Johansson
2007-10-10 0:18 ` Stephen Rothwell
2007-10-10 0:18 ` Stephen Rothwell
2007-10-10 0:38 ` [PATCH v2] " Olof Johansson
2007-10-10 10:08 ` Milton Miller
2007-10-10 10:08 ` Milton Miller
2007-10-10 16:43 ` Olof Johansson
2007-10-10 16:43 ` Olof Johansson
2007-10-11 15:25 ` Milton Miller
2007-10-11 5:52 ` Paul Mackerras
2007-10-11 5:59 ` Olof Johansson
2007-10-11 21:42 ` Milton Miller
2007-10-11 0:24 ` [stable] [patch 09/12] Fix SMP poweroff hangs Paul Mackerras
2007-10-09 23:28 ` Greg KH
[not found] ` <alpine.LFD.0.999.0710091625520.3838@woody.linux%foundation.org>
2007-10-10 10:06 ` Milton Miller
2007-10-10 10:06 ` Milton Miller
2007-10-10 11:35 ` Rafael J. Wysocki
2007-10-10 11:35 ` Rafael J. Wysocki
2007-10-08 18:06 ` [patch 10/12] Fix timer_stats printout of events/sec Greg KH
2007-10-08 18:06 ` [patch 11/12] SELinux: clear parent death signal on SID transitions Greg KH
2007-10-08 18:06 ` [patch 12/12] i386: Use global flag to disable broken local apic timer on AMD CPUs Greg KH
2007-10-08 18:09 ` [patch 00/12] 2.6.22.10 -stable review Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071011191917.GA11732@redhat.com \
--to=davej@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=cavokz@gmail.com \
--cc=cebbert@redhat.com \
--cc=chuckw@quantumlinux.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=jgarzik@pobox.com \
--cc=jmforbes@linuxtx.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrufky@linuxtv.org \
--cc=mlord@pobox.com \
--cc=olof@lixom.net \
--cc=rdunlap@xenotime.net \
--cc=reviews@ml.cw.f00f.org \
--cc=rjw@sisk.pl \
--cc=sfr@canb.auug.org.au \
--cc=spaceman__spiff@cox.net \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=volkerdi@slackware.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.