Re: [PATCH] generic ELF version of grub-mkimage

[Robert Millan <rmh@aybabtu.com>]

On Fri, Oct 12, 2007 at 12:52:42PM +0200, Marco Gerards wrote:
> > 2007-10-12  Robert Millan  <rmh@aybabtu.com>
> >
> > 	* conf/powerpc-ieee1275.rmk (grub_mkimage_SOURCES): Replace reference
> > 	to util/powerpc/ieee1275/grub-mkimage.c with util/elf/grub-mkimage.c.
> >
> > 	* include/grub/types.h (#ifdef GRUB_CPU_WORDS_BIGENDIAN): Define
> > 	grub_host_to_target16, grub_host_to_target32, grub_host_to_target64,
> > 	grub_target_to_host16, grub_target_to_host32 and grub_target_to_host64.
> > 	(#else): Likewise.
> 
> This syntax is wrong.  It should have been something like:
> 
> > 	* include/grub/types.h (#ifdef GRUB_CPU_WORDS_BIGENDIAN): Define
> > 	grub_host_to_target16, grub_host_to_target32, grub_host_to_target64,
> > 	grub_target_to_host16, grub_target_to_host32 and grub_target_to_host64.
> > 	(#else): Likewise.
> 
>  	* include/grub/types.h (grub_host_to_target16): New macro.
>         (grub_host_to_target32): Likewise.
> 
> etc...

Ok.

> If you are not sure, better wait a few days before committing a
> patch.  Or ask me to double check it.

I *was* sure.  I just happen to be not very good at learning a particular
ChangeLog style.

> > 	* include/grub/powerpc/ieee1275/kernel.h (GRUB_IEEE1275_MOD_ALIGN):
> > 	Renamed from to ...
> > 	(GRUB_MOD_ALIGN): ...this.  Update all users.
> >
> > 	* util/elf/grub-mkimage.c: Replace grub_cpu_to_be16, grub_cpu_to_be32,
> > 	grub_be_to_cpu16 and grub_be_to_cpu32 macros with grub_host_to_target16,
> > 	grub_host_to_target32, grub_target_to_host16 and grub_target_to_host32,
> > 	respectively.
> 
> You know quite well that this is wrong.  You have to mention which
> function you changed.  

Ok.  But no, I didn't really notice.  I'll fix this entry and keep trying to
get it right next time.

> If you use diff -up this is easy to see from the patch.

Sounds very useful, thanks.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)