Re: [PATCH] hiddev: Add 32bit ioctl compatibilty

[Al Viro <viro@ftp.linux.org.uk>]

On Fri, Oct 12, 2007 at 04:51:00PM -0700, Philip Langdale wrote:
> The hiddev driver currently lacks 32bit ioctl compatibility, so
> if you're running with a 64bit kernel and 32bit userspace, it won't
> work.
> 
> I'm pretty sure that the only thing missing is a compat_ioctl
> implementation as all structs have fixed size fields.
> 
> +static long hiddev_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> +{
> +	struct inode *inode = file->f_path.dentry->d_inode;
> +	return hiddev_ioctl(inode, file, cmd, compat_ptr(arg));
> +}

Just how many instances of that sucker do we need?  It's nothing but

     struct inode *inode = file->f_path.dentry->d_inode;
     return file->f_op->ioctl(inode, file, cmd, compat_ptr(arg));