From: Arnd Bergmann <arnd@arndb.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Al Viro <viro@ftp.linux.org.uk>,
Philip Langdale <philipl@overt.org>,
Jiri Kosina <jkosina@suse.cz>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] compat_ioctl: introduce generic_compat_ioctl helper
Date: Sat, 20 Oct 2007 18:23:07 +0200 [thread overview]
Message-ID: <200710201823.07791.arnd@arndb.de> (raw)
In-Reply-To: <20071020161119.GA22065@infradead.org>
On Saturday 20 October 2007, Christoph Hellwig wrote:
> At least for the unlocked_ioctl case this is not nessecary because
> the driver an simply set both the unlocked_ioctl and compat_ioctl
> handlers to the same function. For the drivers not using unlocked_ioctl
> yet a function like this makes sense in theory, but I'd prefer to
> just switch them to ->unlocked_ioctl.
>
There is still the problem with s390 compat_ptr() conversion, a driver
using the same handler for both may interpret a pointer with the high
bit set as out of range.
Arnd <><
prev parent reply other threads:[~2007-10-20 16:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 23:51 [PATCH] hiddev: Add 32bit ioctl compatibilty Philip Langdale
2007-10-13 0:02 ` Al Viro
2007-10-13 17:42 ` Philip Langdale
2007-10-20 15:50 ` [PATCH] compat_ioctl: introduce generic_compat_ioctl helper Arnd Bergmann
2007-10-20 16:03 ` [PATCH] hiddev: simplify 32bit ioctl compatibilty Arnd Bergmann
2007-10-20 16:11 ` [PATCH] compat_ioctl: introduce generic_compat_ioctl helper Christoph Hellwig
2007-10-20 16:23 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710201823.07791.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=hch@infradead.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=philipl@overt.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.