From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: mingo@elte.hu, tglx@linutronix.de,
Anton Blanchard <anton@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Hook compat_sys_nanosleep up to high res timer code
Date: Mon, 15 Oct 2007 00:28:05 +0200 [thread overview]
Message-ID: <200710150028.06493.arnd@arndb.de> (raw)
In-Reply-To: <20071014215437.GF26693@kryten>
On Sunday 14 October 2007, Anton Blanchard wrote:
> Now we have high res timers on ppc64 I thought Id test them. It turns
> out compat_sys_nanosleep hasnt been converted to the hrtimer code and so
> is limited to HZ resolution.
>
> The following patch makes compat_sys_nanosleep call hrtimer_nanosleep
> and uses compat_alloc_user_space to avoid setting KERNEL_DS.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
The code looks correct, but I think it would be nicer to change
hrtimer_nanosleep to take a kernel pointer and have all three
callers (common_nsleep, sys_nanosleep and compat_sys_nanosleep)
do the copy_to_user/put_compat_timespec in the caller.
This would also make it possible to get rid of set_fs() in
compat_sys_clock_nanosleep().
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Anton Blanchard <anton@samba.org>,
mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Hook compat_sys_nanosleep up to high res timer code
Date: Mon, 15 Oct 2007 00:28:05 +0200 [thread overview]
Message-ID: <200710150028.06493.arnd@arndb.de> (raw)
In-Reply-To: <20071014215437.GF26693@kryten>
On Sunday 14 October 2007, Anton Blanchard wrote:
> Now we have high res timers on ppc64 I thought Id test them. It turns
> out compat_sys_nanosleep hasnt been converted to the hrtimer code and so
> is limited to HZ resolution.
>
> The following patch makes compat_sys_nanosleep call hrtimer_nanosleep
> and uses compat_alloc_user_space to avoid setting KERNEL_DS.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
The code looks correct, but I think it would be nicer to change
hrtimer_nanosleep to take a kernel pointer and have all three
callers (common_nsleep, sys_nanosleep and compat_sys_nanosleep)
do the copy_to_user/put_compat_timespec in the caller.
This would also make it possible to get rid of set_fs() in
compat_sys_clock_nanosleep().
Arnd <><
next prev parent reply other threads:[~2007-10-14 22:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-14 21:54 [PATCH] Hook compat_sys_nanosleep up to high res timer code Anton Blanchard
2007-10-14 22:28 ` Arnd Bergmann [this message]
2007-10-14 22:28 ` Arnd Bergmann
2007-10-14 23:16 ` Anton Blanchard
2007-10-15 6:11 ` Thomas Gleixner
2007-10-15 6:11 ` Thomas Gleixner
2007-10-15 6:38 ` [PATCH] Rework hrtimer_nanosleep to make sys_compat_nanosleep easier Anton Blanchard
2007-10-15 6:38 ` Anton Blanchard
2007-10-15 6:43 ` [PATCH] Hook compat_sys_nanosleep up to high res timer code Anton Blanchard
2007-10-15 6:43 ` Anton Blanchard
2007-10-15 7:28 ` [PATCH] Rework hrtimer_nanosleep to make sys_compat_nanosleep easier Arnd Bergmann
2007-10-15 7:28 ` Arnd Bergmann
2007-10-15 21:06 ` Anton Blanchard
2007-10-15 21:13 ` [PATCH] Hook compat_sys_nanosleep up to high res timer code Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710150028.06493.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.