All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Walle <bwalle@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org, ak@suse.de
Subject: Re: [patch 1/2] Add BSS to resource tree
Date: Mon, 15 Oct 2007 23:24:06 +0200	[thread overview]
Message-ID: <20071015212406.GA17804@suse.de> (raw)
In-Reply-To: <20071015113206.36c06361.akpm@linux-foundation.org>

* Andrew Morton <akpm@linux-foundation.org> [2007-10-15 20:32]:
> On Mon, 15 Oct 2007 13:50:43 +0200
> Bernhard Walle <bwalle@suse.de> wrote:
> 
> > --- a/arch/x86/kernel/e820_32.c
> > +++ b/arch/x86/kernel/e820_32.c
> > @@ -51,6 +51,13 @@ struct resource code_resource = {
> >  	.flags	= IORESOURCE_BUSY | IORESOURCE_MEM
> >  };
> >  
> > +struct resource bss_resource = {
> > +	.name	= "Kernel bss",
> > +	.start	= 0,
> > +	.end	= 0,
> > +	.flags	= IORESOURCE_BUSY | IORESOURCE_MEM
> > +};
> > +
> >  static struct resource system_rom_resource = {
> >  	.name	= "System ROM",
> >  	.start	= 0xf0000,
> > @@ -287,6 +294,7 @@ legacy_init_iomem_resources(struct resou
> >  			 */
> >  			request_resource(res, code_resource);
> >  			request_resource(res, data_resource);
> > +			request_resource(res, &bss_resource);
> 
> Looks ungainly, doesn't it?  Perhaps we should add a third arg to
> legacy_init_iomem_resources(), or change legacy_init_iomem_resources() to
> take zero args?  

Yes. But when we change legacy_init_iomem_resources(), then we should
also change efi_initialize_iomem_resources(). But that's declared in
<linux/efi.h> and so a change in ia64 code is required which I wanted
to avoid.

But that patch is for review of the idea. If nobody has objections,
then I'll implement the IA64 change anyway -- and then the 3rd
parameter can be added.


Thanks,
   Bernhard

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Bernhard Walle <bwalle@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, ak@suse.de
Subject: Re: [patch 1/2] Add BSS to resource tree
Date: Mon, 15 Oct 2007 23:24:06 +0200	[thread overview]
Message-ID: <20071015212406.GA17804@suse.de> (raw)
In-Reply-To: <20071015113206.36c06361.akpm@linux-foundation.org>

* Andrew Morton <akpm@linux-foundation.org> [2007-10-15 20:32]:
> On Mon, 15 Oct 2007 13:50:43 +0200
> Bernhard Walle <bwalle@suse.de> wrote:
> 
> > --- a/arch/x86/kernel/e820_32.c
> > +++ b/arch/x86/kernel/e820_32.c
> > @@ -51,6 +51,13 @@ struct resource code_resource = {
> >  	.flags	= IORESOURCE_BUSY | IORESOURCE_MEM
> >  };
> >  
> > +struct resource bss_resource = {
> > +	.name	= "Kernel bss",
> > +	.start	= 0,
> > +	.end	= 0,
> > +	.flags	= IORESOURCE_BUSY | IORESOURCE_MEM
> > +};
> > +
> >  static struct resource system_rom_resource = {
> >  	.name	= "System ROM",
> >  	.start	= 0xf0000,
> > @@ -287,6 +294,7 @@ legacy_init_iomem_resources(struct resou
> >  			 */
> >  			request_resource(res, code_resource);
> >  			request_resource(res, data_resource);
> > +			request_resource(res, &bss_resource);
> 
> Looks ungainly, doesn't it?  Perhaps we should add a third arg to
> legacy_init_iomem_resources(), or change legacy_init_iomem_resources() to
> take zero args?  

Yes. But when we change legacy_init_iomem_resources(), then we should
also change efi_initialize_iomem_resources(). But that's declared in
<linux/efi.h> and so a change in ia64 code is required which I wanted
to avoid.

But that patch is for review of the idea. If nobody has objections,
then I'll implement the IA64 change anyway -- and then the 3rd
parameter can be added.


Thanks,
   Bernhard

  reply	other threads:[~2007-10-15 21:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-15 11:50 [patch 0/2] Protect crashkernel against BSS overlap Bernhard Walle
2007-10-15 11:50 ` Bernhard Walle
2007-10-15 11:50 ` [patch 1/2] Add BSS to resource tree Bernhard Walle
2007-10-15 11:50   ` Bernhard Walle
2007-10-15 18:32   ` Andrew Morton
2007-10-15 18:32     ` Andrew Morton
2007-10-15 21:24     ` Bernhard Walle [this message]
2007-10-15 21:24       ` Bernhard Walle
2007-10-15 11:50 ` [patch 2/2] Check if the crashkernel area is behind BSS Bernhard Walle
2007-10-15 11:50   ` Bernhard Walle
2007-10-16  5:49 ` [patch 0/2] Protect crashkernel against BSS overlap Vivek Goyal
2007-10-16  5:49   ` Vivek Goyal
2007-10-16  9:59   ` Andi Kleen
2007-10-16  9:59     ` Andi Kleen
2007-10-16 16:26     ` Bernhard Walle
2007-10-16 16:26       ` Bernhard Walle
2007-10-16 16:28   ` Bernhard Walle
2007-10-16 16:28     ` Bernhard Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071015212406.GA17804@suse.de \
    --to=bwalle@suse.de \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.