All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-kernel@vger.kernel.org
Cc: Andi Kleen <ak@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: asm-x86/* exported headers using CONFIG_X86_32
Date: Tue, 16 Oct 2007 00:53:58 +0200	[thread overview]
Message-ID: <200710160054.00138.arnd@arndb.de> (raw)

While looking through the new header files, I noticed lots of occurences
of #ifdef CONFIG_X86_32 in headers files exported for glibc.

This is fundamentally broken because user applications including them
do not know about any CONFIG_* symbols, and if they did, those
would incorrectly describe the ABI.

I guess in most cases, the headers that are interesting to user space
can simply be merged without any such #ifdef remaining, but those
that are still needed should be converted to use #ifdef __x86_64__,
which is set by the compiler.
This is how the other architectures avoid this particular problem.

	Arnd <><

             reply	other threads:[~2007-10-15 22:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-15 22:53 Arnd Bergmann [this message]
2007-10-15 23:01 ` asm-x86/* exported headers using CONFIG_X86_32 Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710160054.00138.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.