* asm-x86/* exported headers using CONFIG_X86_32
@ 2007-10-15 22:53 Arnd Bergmann
2007-10-15 23:01 ` Thomas Gleixner
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2007-10-15 22:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Andi Kleen, Andrew Morton, Thomas Gleixner
While looking through the new header files, I noticed lots of occurences
of #ifdef CONFIG_X86_32 in headers files exported for glibc.
This is fundamentally broken because user applications including them
do not know about any CONFIG_* symbols, and if they did, those
would incorrectly describe the ABI.
I guess in most cases, the headers that are interesting to user space
can simply be merged without any such #ifdef remaining, but those
that are still needed should be converted to use #ifdef __x86_64__,
which is set by the compiler.
This is how the other architectures avoid this particular problem.
Arnd <><
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: asm-x86/* exported headers using CONFIG_X86_32
2007-10-15 22:53 asm-x86/* exported headers using CONFIG_X86_32 Arnd Bergmann
@ 2007-10-15 23:01 ` Thomas Gleixner
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2007-10-15 23:01 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: linux-kernel, Andi Kleen, Andrew Morton
On Tue, 16 Oct 2007, Arnd Bergmann wrote:
> While looking through the new header files, I noticed lots of occurences
> of #ifdef CONFIG_X86_32 in headers files exported for glibc.
>
> This is fundamentally broken because user applications including them
> do not know about any CONFIG_* symbols, and if they did, those
> would incorrectly describe the ABI.
>
> I guess in most cases, the headers that are interesting to user space
> can simply be merged without any such #ifdef remaining, but those
> that are still needed should be converted to use #ifdef __x86_64__,
> which is set by the compiler.
> This is how the other architectures avoid this particular problem.
Yup, they slipped through. I have fixups in my pile already. Will send
them tomorrow when I'm actually awake.
tglx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-15 23:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-15 22:53 asm-x86/* exported headers using CONFIG_X86_32 Arnd Bergmann
2007-10-15 23:01 ` Thomas Gleixner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.