All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joseph Fannin <jfannin@gmail.com>
To: linuxppc-dev@ozlabs.org
Cc: linux-fbdev-devel@lists.sourceforge.net
Subject: vga16fb doesn't build on powerpc (vgacon_remap_base)
Date: Tue, 16 Oct 2007 15:14:03 -0400	[thread overview]
Message-ID: <20071016191403.GA5962@nineveh.local> (raw)

vga16fb is an available config option on powerpc, but it won't link
with my .config:

    ERROR: "vgacon_remap_base" [drivers/video/vga16fb.ko] undefined!


I'm guessing this is because include/asm-powerpc/vga.h declares
vgacon_remap_base: 

    extern unsigned long vgacon_remap_base;


...but arch/powerpc/kernel/setup_32.c wraps the definition in an #ifdef:

    #ifdef CONFIG_VGA_CONSOLE
    unsigned long vgacon_remap_base;
    EXPORT_SYMBOL(vgacon_remap_base);
    #endif


So CONFIG_VGA_CONSOLE=n and CONFIG_FB_VGA16=[y|m] won't work.

I've also noticed that the only places in the tree that ever assign
anything to config_remap_base are under arch/ppc.  And
include/asm-powerpc/vga.h also does this:

    #ifdef __powerpc64__
    #define VGA_MAP_MEM(x,s) ((unsigned long) ioremap((x), s))
    #else
    #define VGA_MAP_MEM(x,s) (x + vgacon_remap_base)
    #endif


So VGACON probably doesn't work either on 32bit.  I'm guessing arch/powerpc
doesn't support PREP.

How best could this be fixed up? Or should I just let the thing
be?  This is obviously not a new thing, and I don't have any hardware
that supports this stuff either.

--
Joseph Fannin
jfannin@gmail.com

             reply	other threads:[~2007-10-16 19:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-16 19:14 Joseph Fannin [this message]
2007-10-16 21:31 ` vga16fb doesn't build on powerpc (vgacon_remap_base) Antonino A. Daplas
2007-10-16 21:31   ` [Linux-fbdev-devel] " Antonino A. Daplas
2007-10-17  8:49 ` Geert Uytterhoeven
2007-10-17  8:49   ` Geert Uytterhoeven
2007-10-17  9:01   ` Benjamin Herrenschmidt
2007-10-17  9:01     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071016191403.GA5962@nineveh.local \
    --to=jfannin@gmail.com \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.