All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Antonino A. Daplas" <adaplas@gmail.com>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: vga16fb doesn't build on powerpc	(vgacon_remap_base)
Date: Wed, 17 Oct 2007 05:31:54 +0800	[thread overview]
Message-ID: <1192570314.15588.11.camel@daplas> (raw)
In-Reply-To: <20071016191403.GA5962@nineveh.local>

On Tue, 2007-10-16 at 15:14 -0400, Joseph Fannin wrote:
> vga16fb is an available config option on powerpc, but it won't link
> with my .config:
> 
>     ERROR: "vgacon_remap_base" [drivers/video/vga16fb.ko] undefined!
> 
> 
> I'm guessing this is because include/asm-powerpc/vga.h declares
> vgacon_remap_base: 
> 
>     extern unsigned long vgacon_remap_base;
> 
> 
> ...but arch/powerpc/kernel/setup_32.c wraps the definition in an #ifdef:
> 
>     #ifdef CONFIG_VGA_CONSOLE

Perhaps #if defined(CONFIG_VGA_CONSOLE) || defined(CONFIG_FB_VGA16) ?

or

bool VGA_HARDWARE

#if CONFIG_VGA_HARDWARE
    unsigned long vgacon_remap_base;
    EXPORT_SYMBOL(vgacon_remap_base);
#endif

and for the Kconfig entry of vgacon and vga16fb

select VGA_HARDWARE if PPC32
(or depends on (VGA_HARDWARE && PPC32))

Tony


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

WARNING: multiple messages have this Message-ID (diff)
From: "Antonino A. Daplas" <adaplas@gmail.com>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [Linux-fbdev-devel] vga16fb doesn't build on powerpc (vgacon_remap_base)
Date: Wed, 17 Oct 2007 05:31:54 +0800	[thread overview]
Message-ID: <1192570314.15588.11.camel@daplas> (raw)
In-Reply-To: <20071016191403.GA5962@nineveh.local>

On Tue, 2007-10-16 at 15:14 -0400, Joseph Fannin wrote:
> vga16fb is an available config option on powerpc, but it won't link
> with my .config:
> 
>     ERROR: "vgacon_remap_base" [drivers/video/vga16fb.ko] undefined!
> 
> 
> I'm guessing this is because include/asm-powerpc/vga.h declares
> vgacon_remap_base: 
> 
>     extern unsigned long vgacon_remap_base;
> 
> 
> ...but arch/powerpc/kernel/setup_32.c wraps the definition in an #ifdef:
> 
>     #ifdef CONFIG_VGA_CONSOLE

Perhaps #if defined(CONFIG_VGA_CONSOLE) || defined(CONFIG_FB_VGA16) ?

or

bool VGA_HARDWARE

#if CONFIG_VGA_HARDWARE
    unsigned long vgacon_remap_base;
    EXPORT_SYMBOL(vgacon_remap_base);
#endif

and for the Kconfig entry of vgacon and vga16fb

select VGA_HARDWARE if PPC32
(or depends on (VGA_HARDWARE && PPC32))

Tony

  reply	other threads:[~2007-10-16 21:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-16 19:14 vga16fb doesn't build on powerpc (vgacon_remap_base) Joseph Fannin
2007-10-16 21:31 ` Antonino A. Daplas [this message]
2007-10-16 21:31   ` [Linux-fbdev-devel] " Antonino A. Daplas
2007-10-17  8:49 ` Geert Uytterhoeven
2007-10-17  8:49   ` Geert Uytterhoeven
2007-10-17  9:01   ` Benjamin Herrenschmidt
2007-10-17  9:01     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1192570314.15588.11.camel@daplas \
    --to=adaplas@gmail.com \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.