From: Jens Axboe <jens.axboe@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: fujita.tomonori@lab.ntt.co.jp, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] SPARC64: fix iommu sg chaining
Date: Wed, 17 Oct 2007 10:45:28 +0200 [thread overview]
Message-ID: <20071017084528.GI5043@kernel.dk> (raw)
In-Reply-To: <20071017.014211.41637735.davem@davemloft.net>
On Wed, Oct 17 2007, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Wed, 17 Oct 2007 01:33:25 -0700 (PDT)
>
> > sg_next() gives you a NULL after the last entry, but tests have been
> > changed to compare against sg_last() which is likely not what we
> > want for those checks.
>
> This of course isn't true, ignore me as I'm still learning how this
> new stuff works :-)
Righto, it's invalid to call sg_next() on the last entry! Let me know if
you need any help with debugging this, unfortunately I cannot test on
sparc64 myself...
(I can say that easily, since I know that davem will a) not rest until
this is fixed, and b) is a really good debugger and will not need my
help)
--
Jens Axboe
next prev parent reply other threads:[~2007-10-17 8:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 5:07 [PATCH] SPARC64: fix iommu sg chaining FUJITA Tomonori
2007-10-17 7:21 ` Jens Axboe
2007-10-17 8:33 ` David Miller
2007-10-17 8:42 ` David Miller
2007-10-17 8:45 ` Jens Axboe [this message]
2007-10-17 9:13 ` David Miller
2007-10-17 9:16 ` Jens Axboe
2007-10-17 9:24 ` FUJITA Tomonori
2007-10-17 9:27 ` Jens Axboe
2007-10-17 9:45 ` David Miller
2007-10-17 11:08 ` FUJITA Tomonori
2007-10-17 11:13 ` Jens Axboe
2007-10-17 11:16 ` Jens Axboe
2007-10-17 10:54 ` David Miller
2007-10-17 10:58 ` Jens Axboe
2007-10-17 11:01 ` Jens Axboe
2007-10-17 11:10 ` David Miller
2007-10-17 11:11 ` Jens Axboe
2007-10-17 11:18 ` David Miller
2007-10-17 11:27 ` Jens Axboe
2007-10-17 11:37 ` FUJITA Tomonori
2007-10-17 11:41 ` Jens Axboe
2007-10-17 11:57 ` FUJITA Tomonori
2007-10-17 12:05 ` FUJITA Tomonori
2007-10-17 14:36 ` Jens Axboe
2007-10-17 23:01 ` FUJITA Tomonori
2007-10-17 11:04 ` David Miller
2007-10-17 11:04 ` Jens Axboe
2007-10-17 11:04 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071017084528.GI5043@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=davem@davemloft.net \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.