All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: fujita.tomonori@lab.ntt.co.jp, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH] SPARC64: fix iommu sg chaining
Date: Wed, 17 Oct 2007 13:04:26 +0200	[thread overview]
Message-ID: <20071017110426.GV5043@kernel.dk> (raw)
In-Reply-To: <20071017.040414.55507057.davem@davemloft.net>

On Wed, Oct 17 2007, David Miller wrote:
> From: Jens Axboe <jens.axboe@oracle.com>
> Date: Wed, 17 Oct 2007 12:58:40 +0200
> 
> > The problem is that you cannot zero the entire sg entry, because then
> > you'd potentially overwrite the chain pointer.
> > 
> > I'd propose just adding a
> > 
> >         sg_dma_address(sg) = 0;
> >         sg_dma_len(sg) = 0;
> > 
> > there for now, or provide an arch_clear_sg_entry() helper if we need
> > more killed.
> 
> The "chain pointer" is indicated by an sg->page with the low
> bit set, but we're explicitly initializing it here to a
> non-chain page pointer value.
> 
> What's the problem?

See next mail :-)

-- 
Jens Axboe

  reply	other threads:[~2007-10-17 11:04 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-17  5:07 [PATCH] SPARC64: fix iommu sg chaining FUJITA Tomonori
2007-10-17  7:21 ` Jens Axboe
2007-10-17  8:33   ` David Miller
2007-10-17  8:42     ` David Miller
2007-10-17  8:45       ` Jens Axboe
2007-10-17  9:13         ` David Miller
2007-10-17  9:16           ` Jens Axboe
2007-10-17  9:24             ` FUJITA Tomonori
2007-10-17  9:27               ` Jens Axboe
2007-10-17  9:45               ` David Miller
2007-10-17 11:08                 ` FUJITA Tomonori
2007-10-17 11:13                   ` Jens Axboe
2007-10-17 11:16                     ` Jens Axboe
2007-10-17 10:54             ` David Miller
2007-10-17 10:58               ` Jens Axboe
2007-10-17 11:01                 ` Jens Axboe
2007-10-17 11:10                   ` David Miller
2007-10-17 11:11                     ` Jens Axboe
2007-10-17 11:18                       ` David Miller
2007-10-17 11:27                         ` Jens Axboe
2007-10-17 11:37                   ` FUJITA Tomonori
2007-10-17 11:41                     ` Jens Axboe
2007-10-17 11:57                       ` FUJITA Tomonori
2007-10-17 12:05                         ` FUJITA Tomonori
2007-10-17 14:36                           ` Jens Axboe
2007-10-17 23:01                     ` FUJITA Tomonori
2007-10-17 11:04                 ` David Miller
2007-10-17 11:04                   ` Jens Axboe [this message]
2007-10-17 11:04                 ` FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071017110426.GV5043@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=davem@davemloft.net \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.