All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: Tony Battersby <tonyb@cybernetics.com>
Cc: matthew@wil.cx, linux-scsi@vger.kernel.org,
	James.Bottomley@HansenPartnership.com, protasnb@gmail.com,
	bugme-daemon@bugzilla.kernel.org
Subject: Re: [Bug 3680] sym53c8xx_2 SMP deadlock on driver load
Date: Wed, 17 Oct 2007 17:52:56 +0200	[thread overview]
Message-ID: <20071017155256.GA2820@1wt.eu> (raw)
In-Reply-To: <47162DC8.5050700@cybernetics.com>

On Wed, Oct 17, 2007 at 11:44:08AM -0400, Tony Battersby wrote:
> In 2.4, include/linux/init.h has the following:
> 
> #ifndef MODULE
> #define __init          __attribute__ ((__section__ (".text.init")))
> #else
> #define __init
> #endif
> 
> So __init has an effect only if it is built-in.

Ah yes, you're right.

> Apparently 2.6 also
> discards __init sections in modules after loading, but 2.4 doesn't.  Of
> course, it is still a bug.
> 
> Do you want me to redo the patch with __init taken out?

It would be better. As a general rule of thumb, an __init function should
not be called from a non __init, otherwise it is very hard to track the
call path.

Thanks,
Willy


  reply	other threads:[~2007-10-17 16:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071017013045.A19ED108036@picon.linux-foundation.org>
2007-10-17 14:53 ` [Bug 3680] sym53c8xx_2 SMP deadlock on driver load Tony Battersby
2007-10-17 15:20   ` Willy Tarreau
2007-10-17 15:44     ` Tony Battersby
2007-10-17 15:52       ` Willy Tarreau [this message]
2007-10-17 16:22         ` Tony Battersby
2007-10-17 16:27   ` Matthew Wilcox
2007-10-17 18:46     ` Willy Tarreau
2007-10-17 20:12       ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071017155256.GA2820@1wt.eu \
    --to=w@1wt.eu \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=protasnb@gmail.com \
    --cc=tonyb@cybernetics.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.