From: Jean Delvare <khali@linux-fr.org>
To: Jochen Friedrich <jochen@scram.de>
Cc: linuxppc-embedded@ozlabs.org, linux-kernel@vger.kernel.org,
i2c@lm-sensors.org, Carsten Juttner <carjay@gmx.net>
Subject: Re: [i2c] [PATCH take2] [POWERPC] i2c: adds support for i2c bus on 8xx
Date: Wed, 17 Oct 2007 23:00:27 +0200 [thread overview]
Message-ID: <20071017230027.334a5f48@hyperion.delvare> (raw)
In-Reply-To: <47166085.1010608@scram.de>
On Wed, 17 Oct 2007 21:20:37 +0200, Jochen Friedrich wrote:
> >> + /* Select an arbitrary address. Just make sure it is unique.
> >> + */
> >> + out_8(&i2c->i2c_i2add, 0xfe);
> >>
> >
> > It's a 7-bit address... and are you sure that 0x7e is unique? Does this
> > driver even support slave operation?
> >
>
> It's in fact 0x7F << 1. The same value is used in the 2.4 driver and
> in u-boot, as well. Slave operation is not supported.
I'm not sure what exactly you are doing here, but 0x7f isn't a valid
7-bit I2C address.
--
Jean Delvare
WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: Jochen Friedrich <jochen@scram.de>
Cc: Scott Wood <scottwood@freescale.com>,
Carsten Juttner <carjay@gmx.net>,
linux-kernel@vger.kernel.org, i2c@lm-sensors.org,
linuxppc-embedded@ozlabs.org
Subject: Re: [i2c] [PATCH take2] [POWERPC] i2c: adds support for i2c bus on 8xx
Date: Wed, 17 Oct 2007 23:00:27 +0200 [thread overview]
Message-ID: <20071017230027.334a5f48@hyperion.delvare> (raw)
In-Reply-To: <47166085.1010608@scram.de>
On Wed, 17 Oct 2007 21:20:37 +0200, Jochen Friedrich wrote:
> >> + /* Select an arbitrary address. Just make sure it is unique.
> >> + */
> >> + out_8(&i2c->i2c_i2add, 0xfe);
> >>
> >
> > It's a 7-bit address... and are you sure that 0x7e is unique? Does this
> > driver even support slave operation?
> >
>
> It's in fact 0x7F << 1. The same value is used in the 2.4 driver and
> in u-boot, as well. Slave operation is not supported.
I'm not sure what exactly you are doing here, but 0x7f isn't a valid
7-bit I2C address.
--
Jean Delvare
next prev parent reply other threads:[~2007-10-17 21:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 11:10 [PATCH take2] [POWERPC] i2c: adds support for i2c bus on 8xx Jochen Friedrich
2007-10-15 18:31 ` Scott Wood
2007-10-15 18:31 ` Scott Wood
2007-10-17 19:20 ` Jochen Friedrich
2007-10-17 19:20 ` Jochen Friedrich
2007-10-17 19:35 ` Scott Wood
2007-10-17 19:35 ` Scott Wood
2007-10-17 21:00 ` Jean Delvare [this message]
2007-10-17 21:00 ` [i2c] " Jean Delvare
2007-10-23 15:47 ` Jochen Friedrich
2007-10-23 15:47 ` Jochen Friedrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071017230027.334a5f48@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=carjay@gmx.net \
--cc=i2c@lm-sensors.org \
--cc=jochen@scram.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.