All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Landley <rob@landley.net>
To: David Miller <davem@davemloft.net>
Cc: bunk@kernel.org, James.Bottomley@steeleye.com,
	linux-scsi@vger.kernel.org, sparclinux@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] esp_scsi.c: remove __dev{init,exit}
Date: Thu, 18 Oct 2007 03:18:01 -0500	[thread overview]
Message-ID: <200710180318.01463.rob@landley.net> (raw)
In-Reply-To: <20071011.144928.45188136.davem@davemloft.net>

On Thursday 11 October 2007 4:49:28 pm David Miller wrote:
> From: Rob Landley <rob@landley.net>
> Date: Thu, 11 Oct 2007 17:47:02 -0500
>
> > On Thursday 11 October 2007 10:35:20 am Adrian Bunk wrote:
> > > Since scsi_esp_{,un}register() are EXPORT_SYMBOL'ed, these functions
> > > (and the functions they use) can't be __dev{init,exit}.
> > >
> > > Based on a bug report by Rob Landley.
> > >
> > > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> >
> > Acked-by: Rob Landley <rob@landley.net>
>
> I'm fine with this fix too.
>
> Acked-by: David S. Miller <davem@davemloft.net>

Did this already go to the -stable guys for 2.6.23.2?

Rob
-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

WARNING: multiple messages have this Message-ID (diff)
From: Rob Landley <rob@landley.net>
To: David Miller <davem@davemloft.net>
Cc: bunk@kernel.org, James.Bottomley@steeleye.com,
	linux-scsi@vger.kernel.org, sparclinux@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] esp_scsi.c: remove __dev{init,exit}
Date: Thu, 18 Oct 2007 08:18:01 +0000	[thread overview]
Message-ID: <200710180318.01463.rob@landley.net> (raw)
In-Reply-To: <20071011.144928.45188136.davem@davemloft.net>

On Thursday 11 October 2007 4:49:28 pm David Miller wrote:
> From: Rob Landley <rob@landley.net>
> Date: Thu, 11 Oct 2007 17:47:02 -0500
>
> > On Thursday 11 October 2007 10:35:20 am Adrian Bunk wrote:
> > > Since scsi_esp_{,un}register() are EXPORT_SYMBOL'ed, these functions
> > > (and the functions they use) can't be __dev{init,exit}.
> > >
> > > Based on a bug report by Rob Landley.
> > >
> > > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> >
> > Acked-by: Rob Landley <rob@landley.net>
>
> I'm fine with this fix too.
>
> Acked-by: David S. Miller <davem@davemloft.net>

Did this already go to the -stable guys for 2.6.23.2?

Rob
-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

  reply	other threads:[~2007-10-18  8:18 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-11 10:52 Scsi on sparc build break in 2.6.23 Rob Landley
2007-10-11 10:52 ` Rob Landley
2007-10-11 11:05 ` Adrian Bunk
2007-10-11 11:05   ` Adrian Bunk
2007-10-11 13:17   ` Rob Landley
2007-10-11 13:17     ` Rob Landley
2007-10-11 13:30     ` James Bottomley
2007-10-11 13:30       ` James Bottomley
2007-10-11 15:35       ` [2.6 patch] esp_scsi.c: remove __dev{init,exit} Adrian Bunk
2007-10-11 15:35         ` Adrian Bunk
2007-10-11 21:48         ` Rob Landley
2007-10-11 22:47           ` Rob Landley
2007-10-11 21:49           ` David Miller
2007-10-11 21:49             ` David Miller
2007-10-18  8:18             ` Rob Landley [this message]
2007-10-18  8:18               ` Rob Landley
2007-10-11 15:21     ` Scsi on sparc build break in 2.6.23 Adrian Bunk
2007-10-11 15:21       ` Adrian Bunk
     [not found]       ` <200710111737.30420.rob@landley.net>
2007-10-11 23:56         ` Adrian Bunk
2007-10-11 23:56           ` Adrian Bunk
2007-10-12  0:10           ` Randy Dunlap
2007-10-12  0:10             ` Randy Dunlap
2007-10-13 19:09           ` Rob Landley
2007-10-13 19:09             ` Rob Landley
2007-10-13 19:26             ` Adrian Bunk
2007-10-13 19:26               ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710180318.01463.rob@landley.net \
    --to=rob@landley.net \
    --cc=James.Bottomley@steeleye.com \
    --cc=bunk@kernel.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.