All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@in.ibm.com>
To: "Fernando Luis Vázquez Cao" <fernando@oss.ntt.co.jp>
Cc: akpm@linux-foundation.org, kexec@lists.infradead.org
Subject: Re: [PATCH] kmap leak fix for x86_32 kdump
Date: Thu, 18 Oct 2007 17:51:03 +0530	[thread overview]
Message-ID: <20071018122103.GD8779@in.ibm.com> (raw)
In-Reply-To: <1192705816.23637.12.camel@sebastian.kern.oss.ntt.co.jp>

On Thu, Oct 18, 2007 at 08:10:16PM +0900, Fernando Luis Vázquez Cao wrote:
> copy_oldmem_page should not return leaving a page frame from the
> previous kernel mapped.
> 
> Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
> ---
> 
> diff -urNp linux-2.6.23-git13-orig/arch/x86/kernel/crash_dump_32.c linux-2.6.23-git13/arch/x86/kernel/crash_dump_32.c
> --- linux-2.6.23-git13-orig/arch/x86/kernel/crash_dump_32.c	2007-10-18 19:42:54.000000000 +0900
> +++ linux-2.6.23-git13/arch/x86/kernel/crash_dump_32.c	2007-10-18 19:49:25.000000000 +0900
> @@ -47,6 +47,7 @@ ssize_t copy_oldmem_page(unsigned long p
>  		if (!kdump_buf_page) {
>  			printk(KERN_WARNING "Kdump: Kdump buffer page not"
>  				" allocated\n");
> +			kunmap_atomic(vaddr, KM_PTE0);
>  			return -EFAULT;
>  		}
>  		copy_page(kdump_buf_page, vaddr);
>

Thanks Fernando. This makes sense.

Vivek
 

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

      reply	other threads:[~2007-10-18 12:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-18 11:10 [PATCH] kmap leak fix for x86_32 kdump Fernando Luis Vázquez Cao
2007-10-18 12:21 ` Vivek Goyal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071018122103.GD8779@in.ibm.com \
    --to=vgoyal@in.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=fernando@oss.ntt.co.jp \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.