* [PATCH] kmap leak fix for x86_32 kdump
@ 2007-10-18 11:10 Fernando Luis Vázquez Cao
2007-10-18 12:21 ` Vivek Goyal
0 siblings, 1 reply; 2+ messages in thread
From: Fernando Luis Vázquez Cao @ 2007-10-18 11:10 UTC (permalink / raw)
To: vgoyal, hari; +Cc: akpm, kexec
copy_oldmem_page should not return leaving a page frame from the
previous kernel mapped.
Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
---
diff -urNp linux-2.6.23-git13-orig/arch/x86/kernel/crash_dump_32.c linux-2.6.23-git13/arch/x86/kernel/crash_dump_32.c
--- linux-2.6.23-git13-orig/arch/x86/kernel/crash_dump_32.c 2007-10-18 19:42:54.000000000 +0900
+++ linux-2.6.23-git13/arch/x86/kernel/crash_dump_32.c 2007-10-18 19:49:25.000000000 +0900
@@ -47,6 +47,7 @@ ssize_t copy_oldmem_page(unsigned long p
if (!kdump_buf_page) {
printk(KERN_WARNING "Kdump: Kdump buffer page not"
" allocated\n");
+ kunmap_atomic(vaddr, KM_PTE0);
return -EFAULT;
}
copy_page(kdump_buf_page, vaddr);
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] kmap leak fix for x86_32 kdump
2007-10-18 11:10 [PATCH] kmap leak fix for x86_32 kdump Fernando Luis Vázquez Cao
@ 2007-10-18 12:21 ` Vivek Goyal
0 siblings, 0 replies; 2+ messages in thread
From: Vivek Goyal @ 2007-10-18 12:21 UTC (permalink / raw)
To: Fernando Luis Vázquez Cao; +Cc: akpm, kexec
On Thu, Oct 18, 2007 at 08:10:16PM +0900, Fernando Luis Vázquez Cao wrote:
> copy_oldmem_page should not return leaving a page frame from the
> previous kernel mapped.
>
> Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
> ---
>
> diff -urNp linux-2.6.23-git13-orig/arch/x86/kernel/crash_dump_32.c linux-2.6.23-git13/arch/x86/kernel/crash_dump_32.c
> --- linux-2.6.23-git13-orig/arch/x86/kernel/crash_dump_32.c 2007-10-18 19:42:54.000000000 +0900
> +++ linux-2.6.23-git13/arch/x86/kernel/crash_dump_32.c 2007-10-18 19:49:25.000000000 +0900
> @@ -47,6 +47,7 @@ ssize_t copy_oldmem_page(unsigned long p
> if (!kdump_buf_page) {
> printk(KERN_WARNING "Kdump: Kdump buffer page not"
> " allocated\n");
> + kunmap_atomic(vaddr, KM_PTE0);
> return -EFAULT;
> }
> copy_page(kdump_buf_page, vaddr);
>
Thanks Fernando. This makes sense.
Vivek
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-18 12:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-18 11:10 [PATCH] kmap leak fix for x86_32 kdump Fernando Luis Vázquez Cao
2007-10-18 12:21 ` Vivek Goyal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.