[PATCH] G72 doesn't need ExaCopy workaround

[PATCH] G72 doesn't need ExaCopy workaround

[Jaime Velasco Juan]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

Hi,

I have a G72M wich is very slow when the workaround in NVExaCopy
kicks in. It works much better with the attached patch.

I wonder if that workaround is really needed.

Greetings,
   Jaime


[-- Attachment #2: 0001-G72-doesn-t-need-ExaCopy-workaround.patch --]
[-- Type: text/x-diff, Size: 809 bytes --]

From a7d1e23dcb6713230c15aa97968890c67fc11f4d Mon Sep 17 00:00:00 2001
From: Jaime Velasco Juan <jsagarribay-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Sat, 20 Oct 2007 12:01:59 +0100
Subject: [PATCH] G72 doesn't need ExaCopy workaround

---
 src/nv_exa.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/nv_exa.c b/src/nv_exa.c
index d88d85a..b403072 100644
--- a/src/nv_exa.c
+++ b/src/nv_exa.c
@@ -283,7 +283,6 @@ static void NVExaCopy(PixmapPtr pDstPixmap,
 	if ( ((abs(srcY - dstY)< 16)||(abs(srcX-dstX)<16)) &&
 		((((pNv->Chipset & 0xfff0) == CHIPSET_G70) ||
 		 ((pNv->Chipset & 0xfff0) == CHIPSET_G71) ||
-		 ((pNv->Chipset & 0xfff0) == CHIPSET_G72) ||
 		 ((pNv->Chipset & 0xfff0) == CHIPSET_G73) ||
 		 ((pNv->Chipset & 0xfff0) == CHIPSET_C512))) )
 	{
-- 
1.5.3.3


[-- Attachment #3: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [PATCH] G72 doesn't need ExaCopy workaround

[Maarten Maathuis]

It's entirely possible that your card does not have the bug.

Maybe i can figure out what the original card was with this issue.

Anyone else have an opinion on how to deal with this? (remove the
single entry, or try to narrow it down even further, etc)

Maarten.

On 10/20/07, Jaime Velasco Juan <jsagarribay-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Hi,
>
> I have a G72M wich is very slow when the workaround in NVExaCopy
> kicks in. It works much better with the attached patch.
>
> I wonder if that workaround is really needed.
>
> Greetings,
>    Jaime
>
>
> _______________________________________________
> Nouveau mailing list
> Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> http://lists.freedesktop.org/mailman/listinfo/nouveau
>
>
>

Re: [PATCH] G72 doesn't need ExaCopy workaround

[Stephane Marchesin]

[-- Attachment #1.1: Type: text/plain, Size: 737 bytes --]

On 10/20/07, Maarten Maathuis <madman2003-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> It's entirely possible that your card does not have the bug.


Yeah, we don't know precisely under what circumstances it's triggered. It
seems to be related to texture data caching somehow, but that's all we know.


Maybe i can figure out what the original card was with this issue.
>
> Anyone else have an opinion on how to deal with this? (remove the
> single entry, or try to narrow it down even further, etc)


We could try to use the 3D engine to do copies on nv40, provided there's no
issue with texture caching when doing copies to/from the same surface.

Of course, the best solution is to look at how nvidia implement this.

Stephane

[-- Attachment #1.2: Type: text/html, Size: 1259 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau