From: Greg Banks <gnb@sgi.com>
To: Tom Tucker <tom@opengridcomputing.com>
Cc: bfields@fieldses.org, neilb@suse.de, nfs@lists.sourceforge.net
Subject: Re: [RFC, PATCH 1/4] svc: Fix skip computation in svc_defer and svc_revisit
Date: Tue, 23 Oct 2007 12:45:30 +1000 [thread overview]
Message-ID: <20071023024530.GB6354@sgi.com> (raw)
In-Reply-To: <20071019214523.31422.28978.stgit@dell3.ogc.int>
On Fri, Oct 19, 2007 at 04:45:23PM -0500, Tom Tucker wrote:
>
> The rq_arg.len includes the size of the transport header. The computations
> assumed that it did not.
ok, assuming that your latest svc_rdma_xdr_decode_req(), which I
haven't read yet, doesn't change rq_arg.len as it parses the RDMA
chunking header.
The reason I mention that is that one set of patches I was working
with some time ago had different semantics for rq_arg.len; when
parsing the chunking header, rq_arg.len was adjusted downward as
rq_head[0].iov_base was adjusted forward. This kept rq_arg.len equal
to the sum of rq_{head[0],pages[...],tail[0]}.iov_len, which seemed
like a good idea.
But your way seems valid too.
Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
Apparently, I'm Bedevere. Which MPHG character are you?
I don't speak for SGI.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2007-10-23 2:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 21:40 [RFC, PATCH 0/4] svc: New transport bugs found porting svcrdma Tom Tucker
2007-10-19 21:45 ` [RFC, PATCH 1/4] svc: Fix skip computation in svc_defer and svc_revisit Tom Tucker
2007-10-23 2:45 ` Greg Banks [this message]
2007-10-23 3:11 ` Tom Tucker
2007-10-23 3:52 ` Greg Banks
2007-10-23 18:03 ` J. Bruce Fields
2007-10-24 2:45 ` Greg Banks
2007-10-24 2:53 ` J. Bruce Fields
2007-10-19 21:45 ` [RFC, PATCH 2/4] svc: svc_addsock needs to set the svc_xprt address Tom Tucker
2007-10-22 7:15 ` Greg Banks
2007-10-19 21:45 ` [RFC, PATCH 3/4] svc: Add svc_xprt_names service to replace svc_sock_names Tom Tucker
2007-10-19 21:45 ` [RFC, PATCH 4/4] svc: Move svc_xprt_received call to follow addition of xprt to list Tom Tucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071023024530.GB6354@sgi.com \
--to=gnb@sgi.com \
--cc=bfields@fieldses.org \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
--cc=tom@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.