Re: [RFC, PATCH 1/4] svc: Fix skip computation in svc_defer and svc_revisit

[Tom Tucker <tom@opengridcomputing.com>]

Greg Banks wrote:
> On Fri, Oct 19, 2007 at 04:45:23PM -0500, Tom Tucker wrote:
>   
>> The rq_arg.len includes the size of the transport header. The computations
>> assumed that it did not.
>>     
>
> ok, assuming that your latest svc_rdma_xdr_decode_req(), which I
> haven't read yet, doesn't change rq_arg.len as it parses the RDMA
> chunking header.
>
> The reason I mention that is that one set of patches I was working
> with some time ago had different semantics for rq_arg.len; when
> parsing the chunking header, rq_arg.len was adjusted downward as
> rq_head[0].iov_base was adjusted forward.  This kept rq_arg.len equal
> to the sum of rq_{head[0],pages[...],tail[0]}.iov_len, which seemed
> like a good idea.
>
> But your way seems valid too.
>
>   
Well to be honest, I'm somewhat conflicted. The TCP transport driver 
doesn't include the transport header in rq_arg.len. For the RDMA 
transport, however, there was a lot more parsing involved with the 
transport header and I wanted to keep rq_arg.len inclusive in order to 
enable more robust error checking for short messages, etc...

So right now, it's mixed, but since TCP doesn't save it's transport 
header, it doesn't matter. So to cut to the chase here, the design 
decision being made is that any transport that needs to save it's 
transport header _must_ include the transport header in the rq_arg.len

Tom
> Greg.
>   


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs