Re: [lm-sensors] [patch 1/1] applesmc for Mac Pro 2 x Quad-Core

Re: [lm-sensors] [patch 1/1] applesmc for Mac Pro 2 x Quad-Core

[Mark M. Hoffman]

Hi:

* Andrew Morton <akpm@linux-foundation.org> [2007-10-16 14:19:20 -0700]:
> From: Ren� Rebe <rene@exactcode.de>
> 
> At least the 2x Quad-Core Apple Mac Pro appears to have some over-heat
> protection which suddenly powers off the whole box under load.  This adds
> support for the fans and temerature sensors in the Mac Pro - later some
> "windwarm" a-like code should probably monitor the values.  For now
> manually tweaking the fans prevents the sudden shutdown for me.
> 
> cd /sys/devices/platform/applesmc.768
> for x in fan{1,2,3,4}; do
> 	echo 1 > ${x}_manual
> 	echo 1285 > ${x}_output
> done
> 

Ren�: there is a series of patches for the f75375s hwmon driver that allow fans
to be initialized with platform data.  Although I haven't reviewed the series
in detail yet, IMO the concept looks OK and it may be appropriate for the Macs
also.

http://lists.lm-sensors.org/pipermail/lm-sensors/2007-October/021597.html
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-October/021598.html
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-October/021599.html

> Two sensors are 0, while four are 129 �C, those might be removed again,
> later.
> 
> Signed-off-by: Ren� Rebe <rene@exactcode.de>
> Cc: Mark M. Hoffman <mhoffman@lightlink.com>
> Cc: Nicolas Boichat <nicolas@boichat.ch>
> Cc: Jean Delvare <khali@linux-fr.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/hwmon/applesmc.c |  107 ++++++++++++++++++++++++++++++++++---
>  1 file changed, 101 insertions(+), 6 deletions(-)

Applied to hwmon-2.6.git/testing, thanks.

-- 
Mark M. Hoffman
mhoffman@lightlink.com


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [patch 1/1] applesmc for Mac Pro 2 x Quad-Core

[Jean Delvare]

On Tue, 23 Oct 2007 08:02:39 -0400, Mark M. Hoffman wrote:
> > At least the 2x Quad-Core Apple Mac Pro appears to have some over-heat
> > protection which suddenly powers off the whole box under load.  This adds
> > support for the fans and temerature sensors in the Mac Pro - later some
> > "windwarm" a-like code should probably monitor the values.  For now
> > manually tweaking the fans prevents the sudden shutdown for me.
> > 
> > cd /sys/devices/platform/applesmc.768
> > for x in fan{1,2,3,4}; do
> > 	echo 1 > ${x}_manual
> > 	echo 1285 > ${x}_output
> > done
> 
> René: there is a series of patches for the f75375s hwmon driver that allow fans
> to be initialized with platform data.  Although I haven't reviewed the series
> in detail yet, IMO the concept looks OK and it may be appropriate for the Macs
> also.
> 
> http://lists.lm-sensors.org/pipermail/lm-sensors/2007-October/021597.html
> http://lists.lm-sensors.org/pipermail/lm-sensors/2007-October/021598.html
> http://lists.lm-sensors.org/pipermail/lm-sensors/2007-October/021599.html

I still need to be convinced why this has to be hard-coded in the
kernel when the same can be done, and fine-tuned, in user-space just
fine.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [patch 1/1] applesmc for Mac Pro 2 x Quad-Core

[Mark M. Hoffman]

Hi Jean:

* Jean Delvare <khali@linux-fr.org> [2007-10-23 23:01:36 +0200]:
> On Tue, 23 Oct 2007 08:02:39 -0400, Mark M. Hoffman wrote:
> > > At least the 2x Quad-Core Apple Mac Pro appears to have some over-heat
> > > protection which suddenly powers off the whole box under load.  This adds
> > > support for the fans and temerature sensors in the Mac Pro - later some
> > > "windwarm" a-like code should probably monitor the values.  For now
> > > manually tweaking the fans prevents the sudden shutdown for me.
> > > 
> > > cd /sys/devices/platform/applesmc.768
> > > for x in fan{1,2,3,4}; do
> > > 	echo 1 > ${x}_manual
> > > 	echo 1285 > ${x}_output
> > > done
> > 
> > René: there is a series of patches for the f75375s hwmon driver that allow fans
> > to be initialized with platform data.  Although I haven't reviewed the series
> > in detail yet, IMO the concept looks OK and it may be appropriate for the Macs
> > also.
> > 
> > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-October/021597.html
> > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-October/021598.html
> > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-October/021599.html
> 
> I still need to be convinced why this has to be hard-coded in the
> kernel when the same can be done, and fine-tuned, in user-space just
> fine.

For the same reasons that it would be better still if it were done by the BIOS.

When the machine's safety is at stake, you initialize the hardware into a sane,
safe state as early as possible.  Fine tuning is not the issue here.  When you
*know* that the hardware does not come up into a safe state, you should correct
that ASAP.

Say fsck fails out to a shell during early inits... so the fans run full-on,
big deal the machine needs attention anyway.  That sure beats having some
unrelated early userspace problem cause your power supply to catch fire.

Is that good hardware design?  No, but that's irrelevant.

You are going to have to convince *me* why that patch series is a bad idea.

Regards,

-- 
Mark M. Hoffman
mhoffman@lightlink.com


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [patch 1/1] applesmc for Mac Pro 2 x Quad-Core

[Jean Delvare]

On Tue, 23 Oct 2007 20:40:55 -0400, Mark M. Hoffman wrote:
> Hi Jean:
> 
> * Jean Delvare <khali@linux-fr.org> [2007-10-23 23:01:36 +0200]:
> > On Tue, 23 Oct 2007 08:02:39 -0400, Mark M. Hoffman wrote:
> > > René: there is a series of patches for the f75375s hwmon driver that allow fans
> > > to be initialized with platform data.  Although I haven't reviewed the series
> > > in detail yet, IMO the concept looks OK and it may be appropriate for the Macs
> > > also.
> > > 
> > > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-October/021597.html
> > > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-October/021598.html
> > > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-October/021599.html
> > 
> > I still need to be convinced why this has to be hard-coded in the
> > kernel when the same can be done, and fine-tuned, in user-space just
> > fine.
> 
> For the same reasons that it would be better still if it were done by the BIOS.
> 
> When the machine's safety is at stake, you initialize the hardware into a sane,
> safe state as early as possible.  Fine tuning is not the issue here.  When you
> *know* that the hardware does not come up into a safe state, you should correct
> that ASAP.
> 
> Say fsck fails out to a shell during early inits... so the fans run full-on,
> big deal the machine needs attention anyway.  That sure beats having some
> unrelated early userspace problem cause your power supply to catch fire.
> 
> Is that good hardware design?  No, but that's irrelevant.
> 
> You are going to have to convince *me* why that patch series is a bad idea.

OK, you're right.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors