From: Arnd Bergmann <arnd@arndb.de>
To: Jeff Garzik <jeff@garzik.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
matthew@wil.cx, ralf@linux-mips.org, adobriyan@gmail.com,
viro@ftp.linux.org.uk, viro@zeniv.linux.org.uk,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/2] irq_flags_t: intro and core annotations
Date: Wed, 24 Oct 2007 10:55:41 +0200 [thread overview]
Message-ID: <200710241055.42567.arnd@arndb.de> (raw)
In-Reply-To: <471EA9D6.9000004@garzik.org>
On Wednesday 24 October 2007, Jeff Garzik wrote:
> >
> > Could we add a debug option that warned if spin_lock_irq is
> > executed with IRQs turned off already?
>
> Seems reasonable but perhaps arch-specific?
>
> Also, I think someone (akpm?) mentioned an effort had been made before,
> and run into some problems. I don't have details...
I already posted a patch in this thread that does exactly that (and
warn about spin_unlock_irq with IRQs enabled), see my earlier reply.
The patch works fine, but my feeling is that it belongs into lockdep
instead.
Arnd <><
next prev parent reply other threads:[~2007-10-24 9:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-20 23:55 [PATCH 1/2] irq_flags_t: intro and core annotations Alexey Dobriyan
2007-10-21 0:54 ` Al Viro
2007-10-21 9:30 ` Alexey Dobriyan
2007-10-22 15:29 ` Ralf Baechle
2007-10-22 18:21 ` Andrew Morton
2007-10-22 18:50 ` Geert Uytterhoeven
2007-10-22 19:10 ` Arnd Bergmann
2007-10-22 19:47 ` Matthew Wilcox
2007-10-22 19:56 ` Linus Torvalds
2007-10-22 20:02 ` Andrew Morton
2007-10-22 21:34 ` Arnd Bergmann
2007-10-22 21:46 ` Thomas Gleixner
2007-10-23 1:06 ` Arnd Bergmann
2007-10-23 1:28 ` USB HCD: avoid duplicate local_irq_disable() Arnd Bergmann
2007-10-23 4:01 ` [linux-usb-devel] " Alan Stern
2007-10-23 4:01 ` Alan Stern
2007-10-25 18:33 ` Greg KH
2007-10-27 19:14 ` Alan Stern
2007-10-27 19:14 ` Alan Stern
2007-10-22 20:47 ` [PATCH 1/2] irq_flags_t: intro and core annotations Jeff Garzik
2007-10-23 0:21 ` David Miller
2007-10-23 3:33 ` Herbert Xu
2007-10-23 3:33 ` Herbert Xu
2007-10-24 2:11 ` Jeff Garzik
2007-10-24 8:55 ` Arnd Bergmann [this message]
2007-10-25 15:40 ` Jan Engelhardt
2007-10-27 20:24 ` Alexey Dobriyan
2007-10-27 20:32 ` Jan Engelhardt
2007-10-28 1:24 ` Herbert Xu
2007-10-27 19:20 ` Roman Zippel
2007-10-27 20:14 ` Alexey Dobriyan
2007-10-27 21:07 ` Peter Zijlstra
2007-10-27 21:22 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710241055.42567.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jeff@garzik.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=ralf@linux-mips.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.