All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Arnd Bergmann <arnd@arndb.de>,
	gregkh@suse.de, linux-arch@vger.kernel.org,
	linux-usb-devel@lists.sourceforge.net, matthew@wil.cx,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	ralf@linux-mips.org, Thomas Gleixner <tglx@linutronix.de>,
	viro@zeniv.linux.org.uk, viro@ftp.linux.org.uk,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	adobriyan@gmail.com
Subject: Re: [linux-usb-devel] USB HCD: avoid duplicate local_irq_disable()
Date: Thu, 25 Oct 2007 11:33:52 -0700	[thread overview]
Message-ID: <20071025183352.GB2176@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0710222359290.13902-100000@netrider.rowland.org>

On Tue, Oct 23, 2007 at 12:01:37AM -0400, Alan Stern wrote:
> On Tue, 23 Oct 2007, Arnd Bergmann wrote:
> 
> > usb_hcd_flush_endpoint() has a retry loop that starts with a spin_lock_irq(),
> > but only gives up the spinlock, not the irq_disable before jumping to the
> > rescan label.
> > 
> > Split the spin_lock_irq into the retryable part and the local_irq_disable()
> > that is only done once as a micro-optimization and slight cleanup.
> 
> I agree with your sentiment, but it would be better to solve this 
> problem without using local_irq_disable().  The patch below does this.
> 
> ---
> 
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>

Alan, is this something you want added to the tree and in before 2.6.24
is out?

thanks,

greg k-h

  reply	other threads:[~2007-10-25 18:42 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-20 23:55 [PATCH 1/2] irq_flags_t: intro and core annotations Alexey Dobriyan
2007-10-21  0:54 ` Al Viro
2007-10-21  9:30   ` Alexey Dobriyan
2007-10-22 15:29     ` Ralf Baechle
2007-10-22 18:21       ` Andrew Morton
2007-10-22 18:50         ` Geert Uytterhoeven
2007-10-22 19:10         ` Arnd Bergmann
2007-10-22 19:47           ` Matthew Wilcox
2007-10-22 19:56             ` Linus Torvalds
2007-10-22 20:02               ` Andrew Morton
2007-10-22 21:34                 ` Arnd Bergmann
2007-10-22 21:46                   ` Thomas Gleixner
2007-10-23  1:06                     ` Arnd Bergmann
2007-10-23  1:28                       ` USB HCD: avoid duplicate local_irq_disable() Arnd Bergmann
2007-10-23  4:01                         ` [linux-usb-devel] " Alan Stern
2007-10-23  4:01                           ` Alan Stern
2007-10-25 18:33                           ` Greg KH [this message]
2007-10-27 19:14                             ` Alan Stern
2007-10-27 19:14                               ` Alan Stern
2007-10-22 20:47               ` [PATCH 1/2] irq_flags_t: intro and core annotations Jeff Garzik
2007-10-23  0:21                 ` David Miller
2007-10-23  3:33                 ` Herbert Xu
2007-10-23  3:33                   ` Herbert Xu
2007-10-24  2:11                   ` Jeff Garzik
2007-10-24  8:55                     ` Arnd Bergmann
2007-10-25 15:40 ` Jan Engelhardt
2007-10-27 20:24   ` Alexey Dobriyan
2007-10-27 20:32     ` Jan Engelhardt
2007-10-28  1:24     ` Herbert Xu
2007-10-27 19:20 ` Roman Zippel
2007-10-27 20:14   ` Alexey Dobriyan
2007-10-27 21:07     ` Peter Zijlstra
2007-10-27 21:22     ` Roman Zippel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071025183352.GB2176@kroah.com \
    --to=greg@kroah.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=gregkh@suse.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=ralf@linux-mips.org \
    --cc=stern@rowland.harvard.edu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@ftp.linux.org.uk \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.