From: Samuel Thibault <samuel.thibault@xensource.com>
To: xen-devel@lists.xensource.com
Subject: Re: [PATCH] Mini-os xenbus wait fixup
Date: Wed, 24 Oct 2007 14:31:26 +0100 [thread overview]
Message-ID: <20071024133126.GD3824@implementation.uk.xensource.com> (raw)
In-Reply-To: <20071018145006.GM4003@implementation.uk.xensource.com>
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
Hi,
I'm getting spurious wakes and crashes when using xenbus_wake_for_value.
It looks to me like the attached patch is needed because else the wait
element is kept in the watch queue (just like in the wait_event() macro,
and it does fix my issues).
Samuel
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 390 bytes --]
diff -r b28ae5f00553 extras/mini-os/xenbus/xenbus.c
--- a/extras/mini-os/xenbus/xenbus.c Tue Oct 23 09:26:43 2007 +0100
+++ b/extras/mini-os/xenbus/xenbus.c Wed Oct 24 14:27:10 2007 +0100
@@ -79,6 +79,7 @@ void wait_for_watch(void)
schedule();
remove_waiter(w);
wake(current);
+ remove_wait_queue(&w);
}
char* xenbus_wait_for_value(const char* path,const char* value)
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
prev parent reply other threads:[~2007-10-24 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 16:23 [PATCH] Mini-os get_current() fixup Samuel Thibault
2007-10-15 16:30 ` Samuel Thibault
[not found] ` <20071018145006.GM4003@implementation.uk.xensource.com>
2007-10-24 13:31 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071024133126.GD3824@implementation.uk.xensource.com \
--to=samuel.thibault@xensource.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.