All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Arjan van de Ven <arjan@infradead.org>
Cc: cpufreq@lists.linux.org.uk, davej@codemonkey.org.uk,
	Adrian Bunk <bunk@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] #if 0 cpufreq.c:cpufreq_get()
Date: Wed, 24 Oct 2007 18:17:52 +0100	[thread overview]
Message-ID: <20071024171751.GG32333@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20071024093839.232e5cd5@laptopd505.fenrus.org>

On Wed, Oct 24, 2007 at 09:38:39AM -0700, Arjan van de Ven wrote:
> On Wed, 24 Oct 2007 18:23:12 +0200
> Adrian Bunk <bunk@kernel.org> wrote:
> 
> > cpufreq.c:cpufreq_get() no longer has any user.
> > 
> 
> it's... also a really bad/buggy interface... frquency is a per cpu
> property for one, and constantly changing (esp in a multi-core world)
> even depending on what other parts of the system are doing.

... and such an assumption which would make it impossible to use
the LCD controller on StrongARM-11x0 processors.

This is precisely why we have CPUFREQ - so that hardware which needs
to be re-timed when the CPU frequency changes can get notified of that
event and take the appropriate action.  It exists.  It works.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

WARNING: multiple messages have this Message-ID (diff)
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Adrian Bunk <bunk@kernel.org>,
	davej@codemonkey.org.uk, Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, cpufreq@lists.linux.org.uk
Subject: Re: [2.6 patch] #if 0 cpufreq.c:cpufreq_get()
Date: Wed, 24 Oct 2007 18:17:52 +0100	[thread overview]
Message-ID: <20071024171751.GG32333@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20071024093839.232e5cd5@laptopd505.fenrus.org>

On Wed, Oct 24, 2007 at 09:38:39AM -0700, Arjan van de Ven wrote:
> On Wed, 24 Oct 2007 18:23:12 +0200
> Adrian Bunk <bunk@kernel.org> wrote:
> 
> > cpufreq.c:cpufreq_get() no longer has any user.
> > 
> 
> it's... also a really bad/buggy interface... frquency is a per cpu
> property for one, and constantly changing (esp in a multi-core world)
> even depending on what other parts of the system are doing.

... and such an assumption which would make it impossible to use
the LCD controller on StrongARM-11x0 processors.

This is precisely why we have CPUFREQ - so that hardware which needs
to be re-timed when the CPU frequency changes can get notified of that
event and take the appropriate action.  It exists.  It works.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

  reply	other threads:[~2007-10-24 17:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-24 16:23 [2.6 patch] #if 0 cpufreq.c:cpufreq_get() Adrian Bunk
2007-10-24 16:32 ` Russell King
2007-10-24 16:32   ` Russell King
2007-10-24 16:46   ` Adrian Bunk
2007-10-24 16:46     ` Adrian Bunk
2007-10-24 16:38 ` Arjan van de Ven
2007-10-24 16:38   ` Arjan van de Ven
2007-10-24 17:17   ` Russell King [this message]
2007-10-24 17:17     ` Russell King
2007-10-24 17:34   ` Dominik Brodowski
2007-10-24 18:39 ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071024171751.GG32333@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=arjan@infradead.org \
    --cc=bunk@kernel.org \
    --cc=cpufreq@lists.linux.org.uk \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.