All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] i2c: Fix NACK detection in i2c-pasemi
Date: Wed, 24 Oct 2007 22:13:04 +0000	[thread overview]
Message-ID: <20071024221304.GA31462@lixom.net> (raw)
In-Reply-To: <20071024155917.GA25312@lixom.net>

On Wed, Oct 24, 2007 at 11:39:34PM +0200, Jean Delvare wrote:
> Hi Olof,
> 
> > +	/* Got NACK? */
> > +	if (status & SMSTA_MTN)
> > +		return -ENODEV;
> 
> What does the SMSTA_MTN bit mean exactly? If it is raised by any NACK,
> then it doesn't necessarily mean "no device". It can also mean that the
> slave didn't like the transaction for any reason. In this case -ENODEV
> is too specific and you should instead return -ENXIO or maybe -EINVAL.
> 
> It's up to i2c-core to convert the error code to -ENODEV if it happens
> during device probing.

Yes, it could be raised by any NACK. Want me to respin and resend or
are you OK with editing before committing?


Thanks for your feedback,

-Olof

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2007-10-24 22:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-24 15:59 [lm-sensors] [PATCH] i2c: Fix NACK detection in i2c-pasemi Olof Johansson
2007-10-24 21:39 ` Jean Delvare
2007-10-24 22:13 ` Olof Johansson [this message]
2007-10-25 13:27 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071024221304.GA31462@lixom.net \
    --to=olof@lixom.net \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.