From: David Miller <davem@davemloft.net>
To: ebiederm@xmission.com
Cc: benjamin.thery@bull.net, netdev@vger.kernel.org,
dlunev@gmail.com, containers@lists.osdl.org, clg@fr.ibm.com,
xemul@openvz.org
Subject: Re: [PATCH] net: Marking struct pernet_operations __net_initdata was inappropriate
Date: Fri, 26 Oct 2007 22:55:16 -0700 (PDT) [thread overview]
Message-ID: <20071026.225516.152502425.davem@davemloft.net> (raw)
In-Reply-To: <m1hckdwici.fsf_-_@ebiederm.dsl.xmission.com>
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Fri, 26 Oct 2007 17:45:33 -0600
>
> It is not safe to to place struct pernet_operations in a special section.
> We need struct pernet_operations to last until we call unregister_pernet_subsys.
> Which doesn't happen until module unload.
>
> So marking struct pernet_operations is a disaster for modules in two ways.
> - We discard it before we call the exit method it points to.
> - Because I keep struct pernet_operations on a linked list discarding
> it for compiled in code removes elements in the middle of a linked
> list and does horrible things for linked insert.
>
> So this looks safe assuming __exit_refok is not discarded
> for modules.
>
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Applied, thanks Eric.
Although juding by his comments I though that Denis had different
plans in mind to fix this.
next prev parent reply other threads:[~2007-10-27 5:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 12:59 [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n Benjamin Thery
2007-10-25 14:00 ` Denis V. Lunev
2007-10-25 14:14 ` [Devel] Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n (resend, was wrong patch) Denis V. Lunev
2007-10-25 14:50 ` [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n Benjamin Thery
2007-10-25 15:04 ` Eric W. Biederman
2007-10-25 15:10 ` Benjamin Thery
2007-10-25 16:39 ` Eric W. Biederman
2007-10-25 16:52 ` Denis V. Lunev
2007-10-25 17:21 ` Eric W. Biederman
2007-10-26 11:31 ` David Miller
2007-10-26 11:41 ` Benjamin Thery
2007-10-26 11:55 ` David Miller
2007-10-26 23:40 ` Eric W. Biederman
2007-10-26 23:45 ` [PATCH] net: Marking struct pernet_operations __net_initdata was inappropriate Eric W. Biederman
2007-10-27 5:55 ` David Miller [this message]
2007-10-27 6:07 ` Eric W. Biederman
2007-10-27 7:29 ` David Miller
2007-10-25 15:03 ` [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071026.225516.152502425.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benjamin.thery@bull.net \
--cc=clg@fr.ibm.com \
--cc=containers@lists.osdl.org \
--cc=dlunev@gmail.com \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.