From: Benjamin Thery <benjamin.thery@bull.net>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Denis V. Lunev" <den@sw.ru>, Pavel Emelianov <xemul@openvz.org>,
David Miller <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
Cedric Le Goater <clg@fr.ibm.com>,
Linux Containers <containers@lists.osdl.org>,
Daniel Lezcano <dlezcano@fr.ibm.com>
Subject: Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n
Date: Thu, 25 Oct 2007 17:10:38 +0200 [thread overview]
Message-ID: <4720B1EE.8050507@bull.net> (raw)
In-Reply-To: <m17ilb6xs9.fsf@ebiederm.dsl.xmission.com>
Eric W. Biederman wrote:
> Benjamin Thery <benjamin.thery@bull.net> writes:
>
>> Denis V. Lunev wrote:
>>> The patch attached should help. The idea is simple. The "init" should be
>>> called only once without NETNS. Period. No need for any lists.
>> This is the kind of idea I had but I didn't think it could be
>> that simple. :)
>> Thanks Denis.
>
> It isn't.
>
>>> I'll resend it to Dave after the ACK.
>> Tested on x86_64 with CONFIG_NET_NS=n and y.
>> It fixes the issue we observed.
>>
>> Acked-by: Benjamin Thery <benjamin.thery@bull.net>
>
> Try rmmod.
rmmod was part of my tests and it does work.
I did:
$ iptables --list
modules x_tables, ip_tables & iptable_filter are loaded
each calling register_pernet_subsys.
$ rmmod iptable_filter ip_tables x_tables
No problem here
$ iptables --list
To be sure I can load the modules again.
>
> Eric
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
B e n j a m i n T h e r y - BULL/DT/Open Software R&D
http://www.bull.com
next prev parent reply other threads:[~2007-10-25 15:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 12:59 [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n Benjamin Thery
2007-10-25 14:00 ` Denis V. Lunev
2007-10-25 14:14 ` [Devel] Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n (resend, was wrong patch) Denis V. Lunev
2007-10-25 14:50 ` [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n Benjamin Thery
2007-10-25 15:04 ` Eric W. Biederman
2007-10-25 15:10 ` Benjamin Thery [this message]
2007-10-25 16:39 ` Eric W. Biederman
2007-10-25 16:52 ` Denis V. Lunev
2007-10-25 17:21 ` Eric W. Biederman
2007-10-26 11:31 ` David Miller
2007-10-26 11:41 ` Benjamin Thery
2007-10-26 11:55 ` David Miller
2007-10-26 23:40 ` Eric W. Biederman
2007-10-26 23:45 ` [PATCH] net: Marking struct pernet_operations __net_initdata was inappropriate Eric W. Biederman
2007-10-27 5:55 ` David Miller
2007-10-27 6:07 ` Eric W. Biederman
2007-10-27 7:29 ` David Miller
2007-10-25 15:03 ` [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4720B1EE.8050507@bull.net \
--to=benjamin.thery@bull.net \
--cc=clg@fr.ibm.com \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=den@sw.ru \
--cc=dlezcano@fr.ibm.com \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.