From: Matthew Wilcox <matthew@wil.cx>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
willy@linux.intel.com, Stephane Eranian <eranian@hpl.hp.com>
Subject: Re: [PATCH 2/5] Use macros instead of TASK_ flags
Date: Fri, 26 Oct 2007 18:33:26 -0600 [thread overview]
Message-ID: <20071027003326.GV27248@parisc-linux.org> (raw)
In-Reply-To: <20071026203941.GA15427@martell.zuzino.mipt.ru>
On Sat, Oct 27, 2007 at 12:39:41AM +0400, Alexey Dobriyan wrote:
> > > - if ((task->state != TASK_STOPPED) && (task->state != TASK_TRACED)) {
> > > + if (!is_task_stopped_or_traced(task)) {
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> I think this is horrible. Are you going to add full blown static inline
> function for every combination of state tests?
No, because we don't need them. Just stopped, traced, stopped_or_traced.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-10-27 0:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 12:24 [PATCH 1/5] Use wake_up_locked() in eventpoll Matthew Wilcox
2007-10-24 12:24 ` [PATCH 2/5] Use macros instead of TASK_ flags Matthew Wilcox
2007-10-25 3:31 ` Andrew Morton
2007-10-26 18:45 ` Andrew Morton
2007-10-26 20:39 ` Alexey Dobriyan
2007-10-27 0:33 ` Matthew Wilcox [this message]
2007-12-05 12:56 ` Ingo Molnar
2007-12-06 14:42 ` Matthew Wilcox
2007-10-24 12:24 ` [PATCH 3/5] Add TASK_WAKEKILL Matthew Wilcox
2007-10-24 12:24 ` [PATCH 4/5] Add lock_page_killable Matthew Wilcox
2007-10-25 4:11 ` Andrew Morton
2007-10-25 4:13 ` Nick Piggin
2007-10-24 12:24 ` [PATCH 5/5] Make wait_on_retry_sync_kiocb killable Matthew Wilcox
2007-10-25 3:43 ` Andrew Morton
2007-10-25 18:31 ` Zach Brown
-- strict thread matches above, loose matches on Subject: below --
2007-10-18 22:25 [PATCH 0/5] TASK_KILLABLE Matthew Wilcox
2007-10-18 22:25 ` [PATCH 2/5] Use macros instead of TASK_ flags Matthew Wilcox
2007-10-25 3:50 ` Nick Piggin
2007-09-02 2:43 [PATCH] TASK_KILLABLE version 2 Matthew Wilcox
2007-09-02 2:46 ` [PATCH 2/5] Use macros instead of TASK_ flags Matthew Wilcox
2007-09-02 2:54 ` Matthew Wilcox
2007-09-02 3:35 ` Daniel Walker
2007-09-02 4:05 ` Matthew Wilcox
2007-09-03 21:03 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071027003326.GV27248@parisc-linux.org \
--to=matthew@wil.cx \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=eranian@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.