From: Ingo Molnar <mingo@elte.hu>
To: Matthew Wilcox <matthew@wil.cx>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH 2/5] Use macros instead of TASK_ flags
Date: Wed, 5 Dec 2007 13:56:22 +0100 [thread overview]
Message-ID: <20071205125622.GA21531@elte.hu> (raw)
In-Reply-To: <1193228698799-git-send-email-matthew@wil.cx>
* Matthew Wilcox <matthew@wil.cx> wrote:
> +#define is_task_stopped(task) ((task->state & TASK_STOPPED) != 0)
> +#define is_task_stopped_or_traced(task) \
> + ((task->state & (TASK_STOPPED | TASK_TRACED)) != 0)
> +#define is_task_loadavg(task) ((task->state & TASK_UNINTERRUPTIBLE) != 0)
1) please change 'is' and 'task' around so that it reads nicer:
if (task_is_stopped(t))
instead of the tongue-twister:
if (is_task_stopped(t))
2) please change task_is_loadavg() to something more sensible - i didnt
know what it meant when i first saw it in -mm's sched.c.
task_is_uninterruptible() would be the logical choice ...
Ingo
next prev parent reply other threads:[~2007-12-05 12:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 12:24 [PATCH 1/5] Use wake_up_locked() in eventpoll Matthew Wilcox
2007-10-24 12:24 ` [PATCH 2/5] Use macros instead of TASK_ flags Matthew Wilcox
2007-10-25 3:31 ` Andrew Morton
2007-10-26 18:45 ` Andrew Morton
2007-10-26 20:39 ` Alexey Dobriyan
2007-10-27 0:33 ` Matthew Wilcox
2007-12-05 12:56 ` Ingo Molnar [this message]
2007-12-06 14:42 ` Matthew Wilcox
2007-10-24 12:24 ` [PATCH 3/5] Add TASK_WAKEKILL Matthew Wilcox
2007-10-24 12:24 ` [PATCH 4/5] Add lock_page_killable Matthew Wilcox
2007-10-25 4:11 ` Andrew Morton
2007-10-25 4:13 ` Nick Piggin
2007-10-24 12:24 ` [PATCH 5/5] Make wait_on_retry_sync_kiocb killable Matthew Wilcox
2007-10-25 3:43 ` Andrew Morton
2007-10-25 18:31 ` Zach Brown
-- strict thread matches above, loose matches on Subject: below --
2007-10-18 22:25 [PATCH 0/5] TASK_KILLABLE Matthew Wilcox
2007-10-18 22:25 ` [PATCH 2/5] Use macros instead of TASK_ flags Matthew Wilcox
2007-10-25 3:50 ` Nick Piggin
2007-09-02 2:43 [PATCH] TASK_KILLABLE version 2 Matthew Wilcox
2007-09-02 2:46 ` [PATCH 2/5] Use macros instead of TASK_ flags Matthew Wilcox
2007-09-02 2:54 ` Matthew Wilcox
2007-09-02 3:35 ` Daniel Walker
2007-09-02 4:05 ` Matthew Wilcox
2007-09-03 21:03 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205125622.GA21531@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@linux-foundation.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.