* [2.6 patch] fix USB_OHCI_HCD_SSB dependencies
@ 2007-10-27 1:06 Adrian Bunk
2007-10-27 8:57 ` Ingo Molnar
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2007-10-27 1:06 UTC (permalink / raw)
To: Ingo Molnar, Michael Buesch, Greg Kroah-Hartman
Cc: linux-kernel, linux-usb-devel
This patch fixes a bug introduced by
commit b22817b3c81cdb18ffe3d2debfee968731a8b5f4.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
155ad66379582067ef2ce73d28e3cf6eedf21b14
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 177e78e..49a91c5 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -156,7 +156,7 @@ config USB_OHCI_HCD_PCI
config USB_OHCI_HCD_SSB
bool "OHCI support for Broadcom SSB OHCI core"
- depends on USB_OHCI_HCD && (SSB = y || SSB = CONFIG_USB_OHCI_HCD) && EXPERIMENTAL
+ depends on USB_OHCI_HCD && (SSB = y || SSB = USB_OHCI_HCD) && EXPERIMENTAL
default n
---help---
Support for the Sonics Silicon Backplane (SSB) attached
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [2.6 patch] fix USB_OHCI_HCD_SSB dependencies
2007-10-27 1:06 [2.6 patch] fix USB_OHCI_HCD_SSB dependencies Adrian Bunk
@ 2007-10-27 8:57 ` Ingo Molnar
2007-10-27 13:45 ` Adrian Bunk
0 siblings, 1 reply; 5+ messages in thread
From: Ingo Molnar @ 2007-10-27 8:57 UTC (permalink / raw)
To: Adrian Bunk
Cc: Michael Buesch, Greg Kroah-Hartman, linux-kernel, linux-usb-devel
* Adrian Bunk <bunk@kernel.org> wrote:
> - depends on USB_OHCI_HCD && (SSB = y || SSB = CONFIG_USB_OHCI_HCD) && EXPERIMENTAL
> + depends on USB_OHCI_HCD && (SSB = y || SSB = USB_OHCI_HCD) && EXPERIMENTAL
oops, indeed ... my Kconfig fu needs strengthening. Does Kconfig warn
somewhere if it sees an erroneous CONFIG_ token?
Ingo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [2.6 patch] fix USB_OHCI_HCD_SSB dependencies
2007-10-27 8:57 ` Ingo Molnar
@ 2007-10-27 13:45 ` Adrian Bunk
2007-10-28 16:15 ` Jeremy Fitzhardinge
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2007-10-27 13:45 UTC (permalink / raw)
To: Ingo Molnar
Cc: Michael Buesch, Greg Kroah-Hartman, linux-kernel, linux-usb-devel
On Sat, Oct 27, 2007 at 10:57:48AM +0200, Ingo Molnar wrote:
>
> * Adrian Bunk <bunk@kernel.org> wrote:
>
> > - depends on USB_OHCI_HCD && (SSB = y || SSB = CONFIG_USB_OHCI_HCD) && EXPERIMENTAL
> > + depends on USB_OHCI_HCD && (SSB = y || SSB = USB_OHCI_HCD) && EXPERIMENTAL
>
> oops, indeed ... my Kconfig fu needs strengthening. Does Kconfig warn
> somewhere if it sees an erroneous CONFIG_ token?
No. IIRC Sam was working in getting warnings for such things, but
currently kconfig simply can't know whether it's a bug or OK.
> Ingo
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [2.6 patch] fix USB_OHCI_HCD_SSB dependencies
2007-10-27 13:45 ` Adrian Bunk
@ 2007-10-28 16:15 ` Jeremy Fitzhardinge
2007-10-28 16:31 ` Robert P. J. Day
0 siblings, 1 reply; 5+ messages in thread
From: Jeremy Fitzhardinge @ 2007-10-28 16:15 UTC (permalink / raw)
To: Adrian Bunk
Cc: Ingo Molnar, Michael Buesch, Greg Kroah-Hartman, linux-kernel,
linux-usb-devel
Adrian Bunk wrote:
> On Sat, Oct 27, 2007 at 10:57:48AM +0200, Ingo Molnar wrote:
>
>> * Adrian Bunk <bunk@kernel.org> wrote:
>>
>>
>>> - depends on USB_OHCI_HCD && (SSB = y || SSB = CONFIG_USB_OHCI_HCD) && EXPERIMENTAL
>>> + depends on USB_OHCI_HCD && (SSB = y || SSB = USB_OHCI_HCD) && EXPERIMENTAL
>>>
>> oops, indeed ... my Kconfig fu needs strengthening. Does Kconfig warn
>> somewhere if it sees an erroneous CONFIG_ token?
>>
>
> No. IIRC Sam was working in getting warnings for such things, but
> currently kconfig simply can't know whether it's a bug or OK.
>
Are there any instances of CONFIG_CONFIG_X? Doesn't seem like a
terribly sensible name...
J
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [2.6 patch] fix USB_OHCI_HCD_SSB dependencies
2007-10-28 16:15 ` Jeremy Fitzhardinge
@ 2007-10-28 16:31 ` Robert P. J. Day
0 siblings, 0 replies; 5+ messages in thread
From: Robert P. J. Day @ 2007-10-28 16:31 UTC (permalink / raw)
To: Jeremy Fitzhardinge
Cc: Adrian Bunk, Ingo Molnar, Michael Buesch, Greg Kroah-Hartman,
linux-kernel, linux-usb-devel
On Sun, 28 Oct 2007, Jeremy Fitzhardinge wrote:
> Adrian Bunk wrote:
> > On Sat, Oct 27, 2007 at 10:57:48AM +0200, Ingo Molnar wrote:
> >
> >> * Adrian Bunk <bunk@kernel.org> wrote:
> >>
> >>
> >>> - depends on USB_OHCI_HCD && (SSB = y || SSB = CONFIG_USB_OHCI_HCD) && EXPERIMENTAL
> >>> + depends on USB_OHCI_HCD && (SSB = y || SSB = USB_OHCI_HCD) && EXPERIMENTAL
> >>>
> >> oops, indeed ... my Kconfig fu needs strengthening. Does Kconfig warn
> >> somewhere if it sees an erroneous CONFIG_ token?
> >>
> >
> > No. IIRC Sam was working in getting warnings for such things, but
> > currently kconfig simply can't know whether it's a bug or OK.
>
> Are there any instances of CONFIG_CONFIG_X? Doesn't seem like a
> terribly sensible name...
there used to be:
http://lists.linuxcoding.com/kernel/2006-q1/msg18685.html
but that was just the one, and it's gone now.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://crashcourse.ca
========================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-10-28 16:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-27 1:06 [2.6 patch] fix USB_OHCI_HCD_SSB dependencies Adrian Bunk
2007-10-27 8:57 ` Ingo Molnar
2007-10-27 13:45 ` Adrian Bunk
2007-10-28 16:15 ` Jeremy Fitzhardinge
2007-10-28 16:31 ` Robert P. J. Day
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.