* [PATCH] compat_ioctl: fix block device compat ioctl regression [not found] ` <47228A9E.80505@overt.org> @ 2007-10-27 9:38 ` Arnd Bergmann 2007-10-27 11:34 ` Jens Axboe 0 siblings, 1 reply; 3+ messages in thread From: Arnd Bergmann @ 2007-10-27 9:38 UTC (permalink / raw) To: akpm, linuxppc-dev, Geert Uytterhoeven, Johannes Berg, Jens Axboe Cc: linux-kernel, Philip Langdale From: Philip Langdale <philipl@overt.org> The conversion of handlers to compat_blkdev_ioctl accidentally disabled handling of most ioctl numbers on block devices because of a typo. Fix the one line to enable it all again. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- Mea Culpa. This should have been found by my testing, as it's clear that most of my big patch never worked at all. Sorry for causing problems for everyone involved here. I'm attributing the patch to Philip, as he's the one who pointed out to me what the fix is. Arnd <>< --- a/block/compat_ioctl.c +++ b/block/compat_ioctl.c @@ -581,7 +581,7 @@ static int compat_blkdev_driver_ioctl(struct inode *inode, struct file *file, { int ret; - switch (arg) { + switch (cmd) { case HDIO_GET_UNMASKINTR: case HDIO_GET_MULTCOUNT: case HDIO_GET_KEEPSETTINGS: ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] compat_ioctl: fix block device compat ioctl regression 2007-10-27 9:38 ` [PATCH] compat_ioctl: fix block device compat ioctl regression Arnd Bergmann @ 2007-10-27 11:34 ` Jens Axboe 0 siblings, 0 replies; 3+ messages in thread From: Jens Axboe @ 2007-10-27 11:34 UTC (permalink / raw) To: Arnd Bergmann Cc: linux-kernel, linuxppc-dev, Geert Uytterhoeven, akpm, Johannes Berg, Philip Langdale On Sat, Oct 27 2007, Arnd Bergmann wrote: > From: Philip Langdale <philipl@overt.org> > The conversion of handlers to compat_blkdev_ioctl accidentally > disabled handling of most ioctl numbers on block devices because > of a typo. Fix the one line to enable it all again. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > > Mea Culpa. This should have been found by my testing, as it's clear > that most of my big patch never worked at all. Sorry for causing > problems for everyone involved here. > > I'm attributing the patch to Philip, as he's the one who pointed > out to me what the fix is. Oops, added for swift inclusion. -- Jens Axboe ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] compat_ioctl: fix block device compat ioctl regression @ 2007-10-27 11:34 ` Jens Axboe 0 siblings, 0 replies; 3+ messages in thread From: Jens Axboe @ 2007-10-27 11:34 UTC (permalink / raw) To: Arnd Bergmann Cc: akpm, linuxppc-dev, Geert Uytterhoeven, Johannes Berg, linux-kernel, Philip Langdale On Sat, Oct 27 2007, Arnd Bergmann wrote: > From: Philip Langdale <philipl@overt.org> > The conversion of handlers to compat_blkdev_ioctl accidentally > disabled handling of most ioctl numbers on block devices because > of a typo. Fix the one line to enable it all again. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > > Mea Culpa. This should have been found by my testing, as it's clear > that most of my big patch never worked at all. Sorry for causing > problems for everyone involved here. > > I'm attributing the patch to Philip, as he's the one who pointed > out to me what the fix is. Oops, added for swift inclusion. -- Jens Axboe ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-27 11:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <47221F91.60401@overt.org>
[not found] ` <200710270051.38748.arnd@arndb.de>
[not found] ` <47228A9E.80505@overt.org>
2007-10-27 9:38 ` [PATCH] compat_ioctl: fix block device compat ioctl regression Arnd Bergmann
2007-10-27 11:34 ` Jens Axboe
2007-10-27 11:34 ` Jens Axboe
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.