From: Thiemo Seufer <ths@networkno.de>
To: Thayne Harbaugh <thayne@c2.net>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] strace rework
Date: Sat, 27 Oct 2007 14:26:13 +0100 [thread overview]
Message-ID: <20071027132612.GK29176@networkno.de> (raw)
In-Reply-To: <1193063060.5068.45.camel@phantasm.home.enterpriseandprosperity.com>
Thayne Harbaugh wrote:
> This is a rework of Stuart Anderson's strace patch. I've fixed
> target-to-host and host-to-target syscall lookups so that the proper
> host or target errno is returned.
It didn't build for me due to the a missing target_to_host_errno
function. Could you also have a look at the compiler warnings
from strace.c? I see e.g.:
gcc-3.4 -Wall -O2 -g -fno-strict-aliasing -I. -I.. -I/home/ths/qemu/qemu-work/target-ppc -I/home/ths/qemu/qemu-work -I/home/ths/qemu/qemu-work/linux-user -I/home/ths/qemu/qemu-work/linux-user/ppc -D__powerpc__ -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -I/home/ths/qemu/qemu-work/fpu -DHAS_AUDIO -DHAS_AUDIO_CHOICE -I/home/ths/qemu/qemu-work/slirp -c -o strace.o /home/ths/qemu/qemu-work/linux-user/strace.c
/home/ths/qemu/qemu-work/linux-user/strace.c: In function `print_newselect':
/home/ths/qemu/qemu-work/linux-user/strace.c:111: warning: int format, long int arg (arg 3)
/home/ths/qemu/qemu-work/linux-user/strace.c:112: warning: passing arg 2 of `print_fdset' makes pointer from integer without a cast
/home/ths/qemu/qemu-work/linux-user/strace.c:114: warning: passing arg 2 of `print_fdset' makes pointer from integer without a cast
/home/ths/qemu/qemu-work/linux-user/strace.c:116: warning: passing arg 2 of `print_fdset' makes pointer from integer without a cast
/home/ths/qemu/qemu-work/linux-user/strace.c:118: warning: passing arg 1 of `print_timeval' makes pointer from integer without a cast
/home/ths/qemu/qemu-work/linux-user/strace.c: In function `print_semctl':
/home/ths/qemu/qemu-work/linux-user/strace.c:133: warning: int format, long int arg (arg 3)
/home/ths/qemu/qemu-work/linux-user/strace.c:133: warning: int format, long int arg (arg 4)
/home/ths/qemu/qemu-work/linux-user/strace.c:135: warning: format argument is not a pointer (arg 2)
/home/ths/qemu/qemu-work/linux-user/strace.c: In function `print_execve':
/home/ths/qemu/qemu-work/linux-user/strace.c:142: warning: initialization makes pointer from integer without a cast
/home/ths/qemu/qemu-work/linux-user/strace.c:145: warning: format argument is not a pointer (arg 3)
/home/ths/qemu/qemu-work/linux-user/strace.c: In function `print_ipc':
/home/ths/qemu/qemu-work/linux-user/strace.c:164: warning: int format, long int arg (arg 3)
/home/ths/qemu/qemu-work/linux-user/strace.c:164: warning: int format, long int arg (arg 4)
/home/ths/qemu/qemu-work/linux-user/strace.c:164: warning: int format, long int arg (arg 5)
/home/ths/qemu/qemu-work/linux-user/strace.c:164: warning: int format, long int arg (arg 6)
/home/ths/qemu/qemu-work/linux-user/strace.c: In function `print_syscall_ret_addr':
/home/ths/qemu/qemu-work/linux-user/strace.c:178: warning: unsigned int format, long int arg (arg 2)
/home/ths/qemu/qemu-work/linux-user/strace.c: In function `print_syscall_ret_raw':
/home/ths/qemu/qemu-work/linux-user/strace.c:185: warning: unsigned int format, long int arg (arg 2)
/home/ths/qemu/qemu-work/linux-user/strace.c: In function `print_syscall_ret_newselect':
/home/ths/qemu/qemu-work/linux-user/strace.c:191: warning: unsigned int format, long int arg (arg 2)
/home/ths/qemu/qemu-work/linux-user/strace.c:192: warning: passing arg 2 of `print_fdset' makes pointer from integer without a cast
/home/ths/qemu/qemu-work/linux-user/strace.c:194: warning: passing arg 2 of `print_fdset' makes pointer from integer without a cast
/home/ths/qemu/qemu-work/linux-user/strace.c:196: warning: passing arg 2 of `print_fdset' makes pointer from integer without a cast
/home/ths/qemu/qemu-work/linux-user/strace.c:198: warning: passing arg 1 of `print_timeval' makes pointer from integer without a cast
/home/ths/qemu/qemu-work/linux-user/strace.c: In function `print_syscall':
/home/ths/qemu/qemu-work/linux-user/strace.c:222: warning: implicit declaration of function `getpid'
/home/ths/qemu/qemu-work/linux-user/strace.c: In function `print_syscall_ret':
/home/ths/qemu/qemu-work/linux-user/strace.c:249: warning: int format, long int arg (arg 2)
/home/ths/qemu/qemu-work/linux-user/strace.c:251: warning: int format, long int arg (arg 2)
/home/ths/qemu/qemu-work/linux-user/strace.c: At top level:
/home/ths/qemu/qemu-work/linux-user/strace.c:184: warning: 'print_syscall_ret_raw' defined but not used
Thiemo
next prev parent reply other threads:[~2007-10-27 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 14:24 [Qemu-devel] [PATCH] strace rework Thayne Harbaugh
2007-10-27 13:26 ` Thiemo Seufer [this message]
2007-10-31 15:00 ` Thayne Harbaugh
2007-11-01 0:09 ` Thiemo Seufer
2007-11-01 0:08 ` Thayne Harbaugh
2007-11-01 1:01 ` Thiemo Seufer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071027132612.GK29176@networkno.de \
--to=ths@networkno.de \
--cc=qemu-devel@nongnu.org \
--cc=thayne@c2.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.