From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: Jiri Kosina <jikos@jikos.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Gabriel C <nix.or.die@googlemail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
rtc-linux@googlegroups.com
Subject: Re: BUG: lock held when returning to user space
Date: Mon, 29 Oct 2007 13:20:27 +0100 [thread overview]
Message-ID: <20071029132027.45b51ff8@i1501.lan.towertech.it> (raw)
In-Reply-To: <Pine.LNX.4.64.0710281211170.18815@twin.jikos.cz>
On Sun, 28 Oct 2007 12:12:19 +0100 (CET)
Jiri Kosina <jikos@jikos.cz> wrote:
> On Sat, 27 Oct 2007, Andrew Morton wrote:
>
> > It's a fairly daft thing to do. I think it'd be saner to teach rtc about
> > test_and_set_bit() personally..
>
>
> From: Jiri Kosina <jkosina@suse.cz>
>
> RTC: convert mutex to bitfield
>
> RTC code is using mutex to assure exclusive access to /dev/rtc.
> This is however wrong usage, as it leaves the mutex locked when
> returning into userspace, which is unacceptable.
>
> Convert rtc->char_lock into bit operation.
>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Acked-by: Alessandro Zummo <a.zummo@towertech.it>
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
next prev parent reply other threads:[~2007-10-29 12:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-27 14:19 BUG: lock held when returning to user space Gabriel C
2007-10-27 15:12 ` Jiri Kosina
2007-10-27 15:28 ` Peter Zijlstra
2007-10-27 15:46 ` Andrew Morton
2007-10-28 11:12 ` Jiri Kosina
2007-10-29 12:20 ` Alessandro Zummo [this message]
2007-10-27 16:35 ` Linus Torvalds
2007-10-27 22:47 ` Jiri Kosina
2007-10-29 12:20 ` [rtc-linux] " Alessandro Zummo
2007-10-27 15:47 ` Arjan van de Ven
2007-10-27 16:09 ` Peter Zijlstra
2007-10-27 17:05 ` Arjan van de Ven
-- strict thread matches above, loose matches on Subject: below --
2008-03-12 15:45 Frank Munzert
2008-03-12 16:29 ` Vegard Nossum
2008-03-12 21:40 ` Jiri Kosina
2008-03-13 15:43 ` Daniel Walker
2008-03-13 17:39 ` Peter Zijlstra
2008-03-13 17:56 ` Daniel Walker
2008-03-13 16:49 J.C. Pizarro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071029132027.45b51ff8@i1501.lan.towertech.it \
--to=alessandro.zummo@towertech.it \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=jikos@jikos.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=nix.or.die@googlemail.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.