From: Scott Parish <sRp@srparish.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 6/7] include $PATH in generating list of commands for "help -a"
Date: Mon, 29 Oct 2007 20:00:24 -0700 [thread overview]
Message-ID: <20071030030022.GA2906@srparish.net> (raw)
In-Reply-To: <7vir4ptyc9.fsf@gitster.siamese.dyndns.org>
On Mon, Oct 29, 2007 at 02:17:26PM -0700, Junio C Hamano wrote:
> It's easier to read if you briefly describe the differences
> between the replacement patch and the previous version of the
> patch below the three-dash lines. See for example Lars Knoll's
> patch from today <200710290959.32538.lars@trolltech.com>.
Oh, that's useful information!
For the above patch, were basically what Johannes Schindelin suggested:
+ add_cmdname() now uses ALLOC_GROW and has its lines reordered to be
somewhat cleanre
+ uniq() has lost the curly brackets
+ s/subtract_cmds/exclude_cmds/
+ exclude_cmds() uses an arg name of "path" instead of "dir"
+ exclude_cmd() no longer renames "dir" to "dirp"
+ exclude_cmds() an earlier patch moved the "struct stat" declaration
for no-longer relevant reasons. change removed.
sRp
--
Scott Parish
http://srparish.net/
next prev parent reply other threads:[~2007-10-30 3:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-27 8:36 [PATCH 1/7] "git" returns 1; "git help" and "git help -a" return 0 Scott R Parish
2007-10-27 8:36 ` [PATCH 2/7] remove unused/unneeded "pattern" argument of list_commands Scott R Parish
2007-10-27 8:36 ` [PATCH 3/7] "current_exec_path" is a misleading name, use "argv_exec_path" Scott R Parish
2007-10-27 8:36 ` [PATCH 4/7] list_commands(): simplify code by using chdir() Scott R Parish
2007-10-27 8:36 ` [PATCH 5/7] use only the $PATH for exec'ing git commands Scott R Parish
2007-10-27 8:36 ` [PATCH 6/7] walk $PATH to generate list of commands for "help -a" Scott R Parish
2007-10-27 8:36 ` [PATCH 7/7] shell should call the new setup_path() to setup $PATH Scott R Parish
2007-10-28 6:18 ` [PATCH 6/7] walk $PATH to generate list of commands for "help -a" Junio C Hamano
2007-10-28 9:45 ` Scott Parish
2007-10-28 10:07 ` Junio C Hamano
2007-10-28 11:15 ` Scott Parish
2007-10-28 11:18 ` [PATCH 6/7] include $PATH in generating " Scott R Parish
2007-10-28 11:32 ` Junio C Hamano
2007-10-28 14:39 ` Scott Parish
2007-10-28 14:44 ` Scott R Parish
2007-10-28 16:51 ` Johannes Schindelin
2007-10-29 2:44 ` Scott Parish
2007-10-29 11:30 ` Johannes Schindelin
2007-10-29 11:45 ` David Symonds
2007-10-29 3:30 ` Scott R Parish
2007-10-29 21:17 ` Junio C Hamano
2007-10-30 3:00 ` Scott Parish [this message]
2007-10-28 6:18 ` [PATCH 5/7] use only the $PATH for exec'ing git commands Junio C Hamano
2007-10-28 6:19 ` Adam Roben
2007-10-28 11:17 ` Scott R Parish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030030022.GA2906@srparish.net \
--to=srp@srparish.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.