From: Junio C Hamano <gitster@pobox.com>
To: Scott R Parish <srp@srparish.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 6/7] include $PATH in generating list of commands for "help -a"
Date: Mon, 29 Oct 2007 14:17:26 -0700 [thread overview]
Message-ID: <7vir4ptyc9.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1193628652-15647-1-git-send-email-srp@srparish.net> (Scott R. Parish's message of "Sun, 28 Oct 2007 20:30:52 -0700")
Scott R Parish <srp@srparish.net> writes:
> Git had previously been using the $PATH for scripts--a previous
> patch moved exec'ed commands to also use the $PATH. For consistency
> "help -a" should also list commands in the $PATH.
>
> The main commands are still listed from the git_exec_path(), but
> the $PATH is walked and other git commands (probably extensions) are
> listed.
>
> Signed-off-by: Scott R Parish <srp@srparish.net>
> ---
> help.c | 157 +++++++++++++++++++++++++++++++++++++++++++++++++---------------
> 1 files changed, 120 insertions(+), 37 deletions(-)
Thanks.
It's easier to read if you briefly describe the differences
between the replacement patch and the previous version of the
patch below the three-dash lines. See for example Lars Knoll's
patch from today <200710290959.32538.lars@trolltech.com>.
next prev parent reply other threads:[~2007-10-29 21:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-27 8:36 [PATCH 1/7] "git" returns 1; "git help" and "git help -a" return 0 Scott R Parish
2007-10-27 8:36 ` [PATCH 2/7] remove unused/unneeded "pattern" argument of list_commands Scott R Parish
2007-10-27 8:36 ` [PATCH 3/7] "current_exec_path" is a misleading name, use "argv_exec_path" Scott R Parish
2007-10-27 8:36 ` [PATCH 4/7] list_commands(): simplify code by using chdir() Scott R Parish
2007-10-27 8:36 ` [PATCH 5/7] use only the $PATH for exec'ing git commands Scott R Parish
2007-10-27 8:36 ` [PATCH 6/7] walk $PATH to generate list of commands for "help -a" Scott R Parish
2007-10-27 8:36 ` [PATCH 7/7] shell should call the new setup_path() to setup $PATH Scott R Parish
2007-10-28 6:18 ` [PATCH 6/7] walk $PATH to generate list of commands for "help -a" Junio C Hamano
2007-10-28 9:45 ` Scott Parish
2007-10-28 10:07 ` Junio C Hamano
2007-10-28 11:15 ` Scott Parish
2007-10-28 11:18 ` [PATCH 6/7] include $PATH in generating " Scott R Parish
2007-10-28 11:32 ` Junio C Hamano
2007-10-28 14:39 ` Scott Parish
2007-10-28 14:44 ` Scott R Parish
2007-10-28 16:51 ` Johannes Schindelin
2007-10-29 2:44 ` Scott Parish
2007-10-29 11:30 ` Johannes Schindelin
2007-10-29 11:45 ` David Symonds
2007-10-29 3:30 ` Scott R Parish
2007-10-29 21:17 ` Junio C Hamano [this message]
2007-10-30 3:00 ` Scott Parish
2007-10-28 6:18 ` [PATCH 5/7] use only the $PATH for exec'ing git commands Junio C Hamano
2007-10-28 6:19 ` Adam Roben
2007-10-28 11:17 ` Scott R Parish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vir4ptyc9.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=srp@srparish.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.