From: Randy Dunlap <randy.dunlap@oracle.com>
To: Medve Emilian-EMMEDVE1 <Emilian.Medve@freescale.com>
Cc: Greg KH <gregkh@suse.de>,
mochel@osdl.org, linux-kernel@vger.kernel.org, hjlipp@web.de,
tilman@imap.cc, gigaset307x-common@lists.sourceforge.net,
kkeil@suse.de, isdn4linux@listserv.isdn4linux.de, mac@melware.de,
linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH resend] Make the dev_*() family of macros in device.hcomplete
Date: Tue, 30 Oct 2007 08:29:31 -0700 [thread overview]
Message-ID: <20071030082931.113274cc.randy.dunlap@oracle.com> (raw)
In-Reply-To: <598D5675D34BE349929AF5EDE9B03E27016E5FCB@az33exm24.fsl.freescale.net>
On Tue, 30 Oct 2007 05:11:24 -0700 Medve Emilian-EMMEDVE1 wrote:
> Hi Greg K-H,
>
>
> > > +#define dev_info(dev, format, arg...) \
> > > + dev_printk(KERN_INFO, dev, format, ## arg)
> > > +
> > > #ifdef DEBUG
> > > #define dev_dbg(dev, format, arg...) \
> > > - dev_printk(KERN_DEBUG , dev , format , ## arg)
> > > + dev_printk(KERN_DEBUG, dev, format, ## arg)
> >
> > Those extra spaces are there for a good reason, older versions of gcc
> > are broken without it. So please, put them all back...
>
> You mean I should add spaces before commas only where they were
> initially or to all new code and/or macros? I've observed other kernel
> code and more often there are no spaces before commas. I'm asking
> because the CodingStyle document is not very explicit about this rule.
My (hazy?) recollection of the gcc issue is that it is only the
comma before the ## that needs spaces around it.
I'm not even sure that we are still supporting that gcc version,
but you should just put the spaces back to be safe IMO.
---
~Randy
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <randy.dunlap@oracle.com>
To: "Medve Emilian-EMMEDVE1" <Emilian.Medve@freescale.com>
Cc: "Greg KH" <gregkh@suse.de>, <mochel@osdl.org>,
<linux-kernel@vger.kernel.org>, <hjlipp@web.de>, <tilman@imap.cc>,
<gigaset307x-common@lists.sourceforge.net>, <kkeil@suse.de>,
<isdn4linux@listserv.isdn4linux.de>, <mac@melware.de>,
<linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH resend] Make the dev_*() family of macros in device.hcomplete
Date: Tue, 30 Oct 2007 08:29:31 -0700 [thread overview]
Message-ID: <20071030082931.113274cc.randy.dunlap@oracle.com> (raw)
In-Reply-To: <598D5675D34BE349929AF5EDE9B03E27016E5FCB@az33exm24.fsl.freescale.net>
On Tue, 30 Oct 2007 05:11:24 -0700 Medve Emilian-EMMEDVE1 wrote:
> Hi Greg K-H,
>
>
> > > +#define dev_info(dev, format, arg...) \
> > > + dev_printk(KERN_INFO, dev, format, ## arg)
> > > +
> > > #ifdef DEBUG
> > > #define dev_dbg(dev, format, arg...) \
> > > - dev_printk(KERN_DEBUG , dev , format , ## arg)
> > > + dev_printk(KERN_DEBUG, dev, format, ## arg)
> >
> > Those extra spaces are there for a good reason, older versions of gcc
> > are broken without it. So please, put them all back...
>
> You mean I should add spaces before commas only where they were
> initially or to all new code and/or macros? I've observed other kernel
> code and more often there are no spaces before commas. I'm asking
> because the CodingStyle document is not very explicit about this rule.
My (hazy?) recollection of the gcc issue is that it is only the
comma before the ## that needs spaces around it.
I'm not even sure that we are still supporting that gcc version,
but you should just put the spaces back to be safe IMO.
---
~Randy
next prev parent reply other threads:[~2007-10-30 15:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 22:43 [PATCH resend] Make the dev_*() family of macros in device.h complete Emil Medve
2007-10-29 23:08 ` Tilman Schmidt
2007-10-30 0:00 ` Greg KH
2007-10-30 12:11 ` [PATCH resend] Make the dev_*() family of macros in device.hcomplete Medve Emilian-EMMEDVE1
2007-10-30 12:11 ` Medve Emilian-EMMEDVE1
2007-10-30 15:29 ` Randy Dunlap [this message]
2007-10-30 15:29 ` Randy Dunlap
2007-10-30 15:40 ` Greg KH
2007-11-01 23:57 ` Andrew Morton
2007-11-02 11:59 ` Medve Emilian-EMMEDVE1
2007-11-02 11:59 ` Medve Emilian-EMMEDVE1
2007-11-02 15:35 ` Greg KH
2007-11-02 15:35 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030082931.113274cc.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=Emilian.Medve@freescale.com \
--cc=gigaset307x-common@lists.sourceforge.net \
--cc=gregkh@suse.de \
--cc=hjlipp@web.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap-open-source@linux.omap.com \
--cc=mac@melware.de \
--cc=mochel@osdl.org \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.