All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: reiserfs-devel@vger.kernel.org, linux-mm <linux-mm@kvack.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: migratepage failures on reiserfs
Date: Tue, 30 Oct 2007 13:54:42 -0400	[thread overview]
Message-ID: <20071030135442.5d33c61c@think.oraclecorp.com> (raw)
In-Reply-To: <1193768824.8904.11.camel@dyn9047017100.beaverton.ibm.com>

On Tue, 30 Oct 2007 10:27:04 -0800
Badari Pulavarty <pbadari@us.ibm.com> wrote:

> Hi,
> 
> While testing hotplug memory remove, I ran into this issue. Given a
> range of pages hotplug memory remove tries to migrate those pages.
> 
> migrate_pages() keeps failing to migrate pages containing pagecache
> pages for reiserfs files. I noticed that reiserfs doesn't have 
> ->migratepage() ops. So, fallback_migrate_page() code tries to
> do try_to_release_page(). try_to_release_page() fails to
> drop_buffers() since b_count == 1. Here is what my debug shows:
> 
> 	migrate pages failed pfn 258111/flags 3f00000000801
> 	bh c00000000b53f6e0 flags 110029 count 1
> 	
> Any one know why the b_count == 1 and not getting dropped to zero ? 

If these are file data pages, the count is probably elevated as part of
the data=ordered tracking.  You can verify this via b_private, or just
mount data=writeback to double check.

-chris

WARNING: multiple messages have this Message-ID (diff)
From: Chris Mason <chris.mason@oracle.com>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: reiserfs-devel@vger.kernel.org, linux-mm <linux-mm@kvack.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: migratepage failures on reiserfs
Date: Tue, 30 Oct 2007 13:54:42 -0400	[thread overview]
Message-ID: <20071030135442.5d33c61c@think.oraclecorp.com> (raw)
In-Reply-To: <1193768824.8904.11.camel@dyn9047017100.beaverton.ibm.com>

On Tue, 30 Oct 2007 10:27:04 -0800
Badari Pulavarty <pbadari@us.ibm.com> wrote:

> Hi,
> 
> While testing hotplug memory remove, I ran into this issue. Given a
> range of pages hotplug memory remove tries to migrate those pages.
> 
> migrate_pages() keeps failing to migrate pages containing pagecache
> pages for reiserfs files. I noticed that reiserfs doesn't have 
> ->migratepage() ops. So, fallback_migrate_page() code tries to
> do try_to_release_page(). try_to_release_page() fails to
> drop_buffers() since b_count == 1. Here is what my debug shows:
> 
> 	migrate pages failed pfn 258111/flags 3f00000000801
> 	bh c00000000b53f6e0 flags 110029 count 1
> 	
> Any one know why the b_count == 1 and not getting dropped to zero ? 

If these are file data pages, the count is probably elevated as part of
the data=ordered tracking.  You can verify this via b_private, or just
mount data=writeback to double check.

-chris

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-10-30 17:54 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-30 18:27 migratepage failures on reiserfs Badari Pulavarty
2007-10-30 18:27 ` Badari Pulavarty
2007-10-30 17:54 ` Chris Mason [this message]
2007-10-30 17:54   ` Chris Mason
2007-10-30 21:54   ` Badari Pulavarty
2007-10-30 21:54     ` Badari Pulavarty
2007-10-30 22:58     ` Chris Mason
2007-10-30 22:58       ` Chris Mason
2007-10-30 23:08       ` Badari
2007-10-30 23:08         ` Badari
2007-10-31  0:05         ` Zan Lynx
2007-10-31 16:14       ` Badari Pulavarty
2007-10-31 16:14         ` Badari Pulavarty
2007-10-31 17:40         ` Chris Mason
2007-10-31 17:40           ` Chris Mason
2007-11-01 16:38           ` Badari Pulavarty
2007-11-01 16:38             ` Badari Pulavarty
2007-11-01 15:51             ` Chris Mason
2007-11-01 15:51               ` Chris Mason
2007-11-01 18:10               ` Badari Pulavarty
2007-11-01 18:10                 ` Badari Pulavarty
2007-11-02 16:46                 ` Badari Pulavarty
2007-11-02 16:46                   ` Badari Pulavarty
2007-11-05 10:23                 ` Mel Gorman
2007-11-05 10:23                   ` Mel Gorman
2007-11-05 13:40                   ` Chris Mason
2007-11-05 13:40                     ` Chris Mason
2007-11-05 13:40                     ` Chris Mason
2007-11-05 22:46                   ` Christoph Lameter
2007-11-05 22:46                     ` Christoph Lameter
2007-11-07 14:56                     ` Mel Gorman
2007-11-07 14:56                       ` Mel Gorman
2007-11-07 15:58                       ` Badari Pulavarty
2007-11-07 15:58                         ` Badari Pulavarty
2007-11-07 15:58                         ` Badari Pulavarty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071030135442.5d33c61c@think.oraclecorp.com \
    --to=chris.mason@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pbadari@us.ibm.com \
    --cc=reiserfs-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.