From: "John W. Linville" <linville@tuxdriver.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: RTS wrong hdrlen computation?
Date: Tue, 30 Oct 2007 13:28:11 -0400 [thread overview]
Message-ID: <20071030172811.GA7478@tuxdriver.com> (raw)
In-Reply-To: <43e72e890710300956w55740788mc70c63c4bace6d28@mail.gmail.com>
On Tue, Oct 30, 2007 at 12:56:39PM -0400, Luis R. Rodriguez wrote:
> Perhaps an oversight, gotta go so can't keep looking, perhaps others will know
>
> diff --git a/net/mac80211/util.c b/net/mac80211/util.c
> index 27203f1..7f7da9c 100644
> --- a/net/mac80211/util.c
> +++ b/net/mac80211/util.c
> @@ -188,8 +188,11 @@ int ieee80211_get_hdrlen(u16 fc)
> * subtype mask: 0b0000000011110000 (0x00F0)
> * ACK subtype: 0b0000000011010000 (0x00D0)
> * CTS subtype: 0b0000000011000000 (0x00C0)
> + * RTS subtype: 0b0000000010110000 (0x00B0) **
> * bits that matter: ^^^ (0x00E0)
> * value of those: 0b0000000011000000 (0x00C0)
> + *
> + * Note: this doesn't work for RTS...
> */
> if ((fc & 0xE0) == 0xC0)
> hdrlen = 10;
It looks like the default case (i.e. "hdrlen = 16") is fine for RTS.
What am I missing...?
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-10-30 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 16:56 RTS wrong hdrlen computation? Luis R. Rodriguez
2007-10-30 17:28 ` John W. Linville [this message]
2007-10-30 19:01 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030172811.GA7478@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.