* RTS wrong hdrlen computation?
@ 2007-10-30 16:56 Luis R. Rodriguez
2007-10-30 17:28 ` John W. Linville
0 siblings, 1 reply; 3+ messages in thread
From: Luis R. Rodriguez @ 2007-10-30 16:56 UTC (permalink / raw)
To: linux-wireless
Perhaps an oversight, gotta go so can't keep looking, perhaps others will know
diff --git a/net/mac80211/util.c b/net/mac80211/util.c
index 27203f1..7f7da9c 100644
--- a/net/mac80211/util.c
+++ b/net/mac80211/util.c
@@ -188,8 +188,11 @@ int ieee80211_get_hdrlen(u16 fc)
* subtype mask: 0b0000000011110000 (0x00F0)
* ACK subtype: 0b0000000011010000 (0x00D0)
* CTS subtype: 0b0000000011000000 (0x00C0)
+ * RTS subtype: 0b0000000010110000 (0x00B0) **
* bits that matter: ^^^ (0x00E0)
* value of those: 0b0000000011000000 (0x00C0)
+ *
+ * Note: this doesn't work for RTS...
*/
if ((fc & 0xE0) == 0xC0)
hdrlen = 10;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: RTS wrong hdrlen computation?
2007-10-30 16:56 RTS wrong hdrlen computation? Luis R. Rodriguez
@ 2007-10-30 17:28 ` John W. Linville
2007-10-30 19:01 ` Luis R. Rodriguez
0 siblings, 1 reply; 3+ messages in thread
From: John W. Linville @ 2007-10-30 17:28 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linux-wireless
On Tue, Oct 30, 2007 at 12:56:39PM -0400, Luis R. Rodriguez wrote:
> Perhaps an oversight, gotta go so can't keep looking, perhaps others will know
>
> diff --git a/net/mac80211/util.c b/net/mac80211/util.c
> index 27203f1..7f7da9c 100644
> --- a/net/mac80211/util.c
> +++ b/net/mac80211/util.c
> @@ -188,8 +188,11 @@ int ieee80211_get_hdrlen(u16 fc)
> * subtype mask: 0b0000000011110000 (0x00F0)
> * ACK subtype: 0b0000000011010000 (0x00D0)
> * CTS subtype: 0b0000000011000000 (0x00C0)
> + * RTS subtype: 0b0000000010110000 (0x00B0) **
> * bits that matter: ^^^ (0x00E0)
> * value of those: 0b0000000011000000 (0x00C0)
> + *
> + * Note: this doesn't work for RTS...
> */
> if ((fc & 0xE0) == 0xC0)
> hdrlen = 10;
It looks like the default case (i.e. "hdrlen = 16") is fine for RTS.
What am I missing...?
John
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: RTS wrong hdrlen computation?
2007-10-30 17:28 ` John W. Linville
@ 2007-10-30 19:01 ` Luis R. Rodriguez
0 siblings, 0 replies; 3+ messages in thread
From: Luis R. Rodriguez @ 2007-10-30 19:01 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless
On 10/30/07, John W. Linville <linville@tuxdriver.com> wrote:
> On Tue, Oct 30, 2007 at 12:56:39PM -0400, Luis R. Rodriguez wrote:
> > Perhaps an oversight, gotta go so can't keep looking, perhaps others will know
> >
> > diff --git a/net/mac80211/util.c b/net/mac80211/util.c
> > index 27203f1..7f7da9c 100644
> > --- a/net/mac80211/util.c
> > +++ b/net/mac80211/util.c
> > @@ -188,8 +188,11 @@ int ieee80211_get_hdrlen(u16 fc)
> > * subtype mask: 0b0000000011110000 (0x00F0)
> > * ACK subtype: 0b0000000011010000 (0x00D0)
> > * CTS subtype: 0b0000000011000000 (0x00C0)
> > + * RTS subtype: 0b0000000010110000 (0x00B0) **
> > * bits that matter: ^^^ (0x00E0)
> > * value of those: 0b0000000011000000 (0x00C0)
> > + *
> > + * Note: this doesn't work for RTS...
> > */
> > if ((fc & 0xE0) == 0xC0)
> > hdrlen = 10;
>
> It looks like the default case (i.e. "hdrlen = 16") is fine for RTS.
> What am I missing...?
Sorry had a bad morning, you're right..
Luis
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-30 19:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-30 16:56 RTS wrong hdrlen computation? Luis R. Rodriguez
2007-10-30 17:28 ` John W. Linville
2007-10-30 19:01 ` Luis R. Rodriguez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.