From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] include/asm-arm/arch-omap/omap24xx.h
Date: Wed, 31 Oct 2007 08:22:30 -0700 [thread overview]
Message-ID: <20071031152230.GP32547@atomide.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0710250955270.25986@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [071025 09:01]:
> Hello Dirk,
>
> On Thu, 25 Oct 2007, Dirk Behme wrote:
>
>> Mmh, I like to fix it in include/asm-arm/arch-omap/omap24xx.h, so I prefer
>> [1].
>>
>> With [1] we
>>
>> - fix it where it was introduced
>> - have an additional #ifdef only in a header file instead of
>> plat-omap/devices.c, which is IMHO better
>> - fix it for everybody now and in the future who directly or indirectly
>> includes omap24xx.h.
>
> Hopefully this is just a workaround until we can get rid of these
> conditional defines for multiboot kernels. Generally speaking, would you
> propose doing the same thing for the other conditional defines in
> include/asm-arm/arch-omap/omap24xx.h, such as OMAP2_32KSYNCT_BASE,
> OMAP2_SDRC_BASE, etc.?
Sounds like the real fix is to set these addresses in the init code
somewhere based on the omap type.
Tony
next prev parent reply other threads:[~2007-10-31 15:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 16:58 [PATCH] include/asm-arm/arch-omap/omap24xx.h Luís Cargnini
2007-10-24 17:53 ` Dirk Behme
2007-10-25 5:31 ` Paul Walmsley
2007-10-25 5:31 ` fix undeclared OMAP2_CTRL_BASE for OMAP MMC driver in OMAP1 compiles Paul Walmsley
2007-10-25 5:54 ` [PATCH] include/asm-arm/arch-omap/omap24xx.h Luís Cargnini
2007-10-25 15:28 ` Dirk Behme
2007-10-25 16:00 ` Paul Walmsley
2007-10-31 15:22 ` Tony Lindgren [this message]
2007-11-01 8:29 ` Tony Lindgren
2007-11-05 7:57 ` Paul Walmsley
2007-11-05 19:34 ` Dirk Behme
2007-11-06 10:23 ` Paul Walmsley
2007-11-06 12:58 ` Tony Lindgren
2007-11-07 4:21 ` Luís Cargnini
-- strict thread matches above, loose matches on Subject: below --
2007-11-07 4:27 [PATCH]include/asm-arm/arch-omap/omap24xx.h Luís Cargnini
2007-11-15 21:24 ` [PATCH]include/asm-arm/arch-omap/omap24xx.h Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071031152230.GP32547@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.