From: Dirk Behme <dirk.behme@googlemail.com>
To: lvcargnini@gmail.com, Tony Lindgren <tony@atomide.com>
Cc: OMAP <Linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH] include/asm-arm/arch-omap/omap24xx.h
Date: Wed, 24 Oct 2007 19:53:14 +0200 [thread overview]
Message-ID: <471F868A.3060106@googlemail.com> (raw)
In-Reply-To: <ae36f8040710240958l579ad5el16f17cb073e25387@mail.gmail.com>
Luís Cargnini wrote:
> I are resubmitting this patch again, because even now this patch was
> not applied on main tree, I upgraded yesterday for the
> linux-2.6.23-omap1 (latest tag)
> and it still not pushed into main tree, please someone add this patch.
>
> Signed-off-by: Luís Vitório Cargnini <lvcargnini at gmail.com>
>
> Signed-off-by: Dirk Behme <dirk.behme at gmail.com
> <http://linux.omap.com/mailman/listinfo/linux-omap-open-source>>
> -------------- next part --------------
> Index: linux-osk/include/asm-arm/arch-omap/omap24xx.h
> ===================================================================
> --- linux-osk.orig/include/asm-arm/arch-omap/omap24xx.h
> +++ linux-osk/include/asm-arm/arch-omap/omap24xx.h
> @@ -103,6 +103,11 @@
>
> #endif
>
> +#if !defined(OMAP2_CTRL_BASE)
> +/* If no one of the above configs is selected, use default */
> +#define OMAP2_CTRL_BASE L4_24XX_BASE
> +#endif
> +
> /* Control module */
> #define OMAP2_CONTROL_DEVCONF0 (OMAP2_CTRL_BASE + 0x274)
> #define OMAP2_CONTROL_DEVCONF1 (OMAP2_CTRL_BASE + 0x2e8)
Seems that this wasn't applied because Tony mentioned that this should
not be needed any longer:
http://linux.omap.com/pipermail/linux-omap-open-source/2007-October/011525.html
I didn't check this that time. But checking today, it is still broken.
Reproducable by using omap_osk_5912_defconfig with additional MMC
enabled. So right, anything like this should be applied.
Cheers
Dirk
next prev parent reply other threads:[~2007-10-24 17:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 16:58 [PATCH] include/asm-arm/arch-omap/omap24xx.h Luís Cargnini
2007-10-24 17:53 ` Dirk Behme [this message]
2007-10-25 5:31 ` Paul Walmsley
2007-10-25 5:31 ` fix undeclared OMAP2_CTRL_BASE for OMAP MMC driver in OMAP1 compiles Paul Walmsley
2007-10-25 5:54 ` [PATCH] include/asm-arm/arch-omap/omap24xx.h Luís Cargnini
2007-10-25 15:28 ` Dirk Behme
2007-10-25 16:00 ` Paul Walmsley
2007-10-31 15:22 ` Tony Lindgren
2007-11-01 8:29 ` Tony Lindgren
2007-11-05 7:57 ` Paul Walmsley
2007-11-05 19:34 ` Dirk Behme
2007-11-06 10:23 ` Paul Walmsley
2007-11-06 12:58 ` Tony Lindgren
2007-11-07 4:21 ` Luís Cargnini
-- strict thread matches above, loose matches on Subject: below --
2007-11-07 4:27 [PATCH]include/asm-arm/arch-omap/omap24xx.h Luís Cargnini
2007-11-15 21:24 ` [PATCH]include/asm-arm/arch-omap/omap24xx.h Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471F868A.3060106@googlemail.com \
--to=dirk.behme@googlemail.com \
--cc=Linux-omap-open-source@linux.omap.com \
--cc=lvcargnini@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.